Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): support compile to wasi target #22870

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge remote-tracking branch 'origin/master' into wasm
  • Loading branch information
FrozenPandaz committed Apr 27, 2024
commit 0f9fdc2f7ec69991ab25541d905975737e16610a
3 changes: 2 additions & 1 deletion .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,8 @@ jobs:
build: |-
set -e &&
rustup target add aarch64-unknown-linux-musl &&
pnpm nx run-many --target=build-native -- --target=aarch64-unknown-linux-musl
pnpm install --frozen-lockfile &&
pnpm nx run-many --verbose --target=build-native -- --target=aarch64-unknown-linux-musl
- host: ubuntu-latest
target: wasm32-wasi-preview1-threads
build: |-
Expand Down
8 changes: 2 additions & 6 deletions packages/nx/src/native/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export class ImportResult {

export class RustPseudoTerminal {
constructor()
runCommand(command: string, commandDir?: string | undefined | null, jsEnv?: Record<string, string> | undefined | null, quiet?: boolean | undefined | null): ChildProcess
runCommand(command: string, commandDir?: string | undefined | null, jsEnv?: Record<string, string> | undefined | null, quiet?: boolean | undefined | null, tty?: boolean | undefined | null): ChildProcess
/**
* This allows us to run a pseudoterminal with a fake node ipc channel
* this makes it possible to be backwards compatible with the old implementation
Expand Down Expand Up @@ -95,11 +95,7 @@ export interface ExternalDependenciesInput {
}

export interface ExternalNode {
version: string
hash?: string
}

export interface ExternalNodeData {
packageName?: string
version: string
hash?: string
}
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.