Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document the default height #529

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

document the default height #529

wants to merge 3 commits into from

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Sep 3, 2021

@Fil Fil mentioned this pull request Sep 3, 2021
@mbostock
Copy link
Member

mbostock commented Sep 7, 2021

I like the notebook, but I’m tempted to make the README description more hand-wavy. I feel like either we explicit document the logic in pseudocode, or we just leave it vague like: “If a height is not specified, Plot will attempt to chose a reasonable default height based on the y and fy scale types and, for ordinal scales, the cardinality of the domain. The default height ranges from TK to TK, with 400 for the common case where y is quantitative and fy is not present.”

@Fil
Copy link
Contributor Author

Fil commented Sep 7, 2021

We could publish the notebook and link to it for details.

@Fil
Copy link
Contributor Author

Fil commented May 31, 2022

(Notebook further updated to take #837 into account.)

@Fil
Copy link
Contributor Author

Fil commented Mar 3, 2023

18 months later, it's published :) https://observablehq.com/@observablehq/plot-default-height

@Fil Fil closed this Mar 3, 2023
@Fil Fil deleted the fil/default-height branch March 3, 2023 08:48
@Fil Fil added the documentation Improvements or additions to docs label Mar 3, 2023
@Fil Fil restored the fil/default-height branch March 3, 2023 08:49
@Fil
Copy link
Contributor Author

Fil commented Mar 3, 2023

didn't mean to close the PR!

@Fil Fil reopened this Mar 3, 2023
@Fil Fil requested a review from mbostock March 3, 2023 08:49
docs/features/plots.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants