-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
document the default height #529
base: main
Are you sure you want to change the base?
Conversation
I like the notebook, but I’m tempted to make the README description more hand-wavy. I feel like either we explicit document the logic in pseudocode, or we just leave it vague like: “If a height is not specified, Plot will attempt to chose a reasonable default height based on the y and fy scale types and, for ordinal scales, the cardinality of the domain. The default height ranges from TK to TK, with 400 for the common case where y is quantitative and fy is not present.” |
We could publish the notebook and link to it for details. |
(Notebook further updated to take #837 into account.) |
18 months later, it's published :) https://observablehq.com/@observablehq/plot-default-height |
didn't mean to close the PR! |
see #337 and https://observablehq.com/@observablehq/plot-default-height
(cheat sheet #318)