Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

radius legends #665

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

radius legends #665

wants to merge 2 commits into from

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Jan 12, 2022

Capture d’écran 2022-01-12 à 12 43 46

It's just one possibility among several

(I've based this on mbostock/arrow since it involves quite a few changes in the legends section)

related: #539 #432 #583

todo:

  • fix circular dependency (maybe rewrite as pure d3?)

@Fil Fil requested a review from mbostock January 12, 2022 11:44
@Fil Fil marked this pull request as ready for review January 12, 2022 11:46
@Fil Fil mentioned this pull request Jan 12, 2022
Base automatically changed from mbostock/arrow to main January 16, 2022 18:08
@Fil
Copy link
Contributor Author

Fil commented Jan 19, 2022

I've fixed the conflict but I now have a circular dependency which I don't know how to fix. Should I rewrite this legend as "pure d3" rather than using Plot?

@Fil Fil marked this pull request as draft January 19, 2022 11:29
This was referenced May 18, 2022
@Fil
Copy link
Contributor Author

Fil commented Feb 16, 2023

As an alternative here's an independent implementation
https://observablehq.com/@recifs/a-radius-legend-for-plot-665

See also discussion #1106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant