-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JavaFX Incubator Modules #1375
base: master
Are you sure you want to change the base?
JavaFX Incubator Modules #1375
Conversation
Initial prototype of a javafx.incubator.controls module
👋 Welcome back kcr! A progress list of the required criteria for merging this PR into |
I pushed the following updates:
|
private static final Module MODULE_JAVA_BASE = Module.class.getModule(); | ||
|
||
@SuppressWarnings("removal") | ||
public static void incubatorWarning() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps we can add a javadoc to this method explaining why it is here and giving a usage example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea.
Incubator warning works as expected:
|
❗ This change is not yet ready to be integrated. |
BTW, should we have a separate, real PR with changes only for enabling the functionality (.md file and build.gradle, the latter with sample module changes commented out - maybe with an easy to grep marker for anyone who wants to add a new incubator module)? |
Yes, something along those lines is in the works. I've already identified many of the changes that would be part of this separate Enhancement, and marked them with I'm not sure yet what the best way is to show where to add the logic for a new incubator module. At least having an easy-to-find "incubator modules go here" comment would be helpful and seems like a good idea. As you suggest, I could go farther than that and add commented-out build logic for the sample module...need to think about that one. I would not be in favor of including the sample module, though, so I'm leaning towards just adding the appropriate markers in build.gradle, but not any actual build logic for an incubator modules. Anyone doing an incubator module would need to grab the sample patch anyway. |
'graphics', | ||
'controls', | ||
// TODO: incubator template | ||
'incubator.myfeature', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change fixed the jenkins build of the rich text area incubator, thank you!
This PR contains a proposal for JavaFX Incubator Modules, along with an example of how such a module might be implemented.
NOTE: This PR will remain in Draft. It is intended only as supporting material for the proposal.
Progress
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1375/head:pull/1375
$ git checkout pull/1375
Update a local copy of the PR:
$ git checkout pull/1375
$ git pull https://git.openjdk.org/jfx.git pull/1375/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1375
View PR using the GUI difftool:
$ git pr show -t 1375
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1375.diff