-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8329011: Update SQLite to 3.45.3 #1454
Conversation
👋 Welcome back hmeda! A progress list of the required criteria for merging this PR into |
@HimaBinduMeda This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Reviewers: @tiainen @kevinrushforth /reviewers 2 |
@johanvos do you also want to review or is Joeri's review OK? |
@kevinrushforth |
In Joeri I trust :) |
Me, too. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything built fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
/integrate |
Going to push as commit 581e3a7. |
@HimaBinduMeda Pushed as commit 581e3a7. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Update SQLite to v3.45.3.Verified build on all platforms. Sanity testing looks fine.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1454/head:pull/1454
$ git checkout pull/1454
Update a local copy of the PR:
$ git checkout pull/1454
$ git pull https://git.openjdk.org/jfx.git pull/1454/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1454
View PR using the GUI difftool:
$ git pr show -t 1454
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1454.diff
Webrev
Link to Webrev Comment