Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8329011: Update SQLite to 3.45.3 #1454

Closed
wants to merge 2 commits into from

Conversation

HimaBinduMeda
Copy link
Contributor

@HimaBinduMeda HimaBinduMeda commented May 14, 2024

Update SQLite to v3.45.3.Verified build on all platforms. Sanity testing looks fine.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1454/head:pull/1454
$ git checkout pull/1454

Update a local copy of the PR:
$ git checkout pull/1454
$ git pull https://git.openjdk.org/jfx.git pull/1454/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1454

View PR using the GUI difftool:
$ git pr show -t 1454

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1454.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 14, 2024

👋 Welcome back hmeda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 14, 2024

@HimaBinduMeda This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8329011: Update SQLite to 3.45.3

Reviewed-by: sykora, kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@HimaBinduMeda HimaBinduMeda changed the title 8329011:Update SQLite to 3.45.3 8329011: Update SQLite to 3.45.3 May 14, 2024
@openjdk openjdk bot added the rfr Ready for review label May 14, 2024
@mlbridge
Copy link

mlbridge bot commented May 14, 2024

Webrevs

@kevinrushforth
Copy link
Member

Reviewers: @tiainen @kevinrushforth

/reviewers 2

@kevinrushforth
Copy link
Member

@johanvos do you also want to review or is Joeri's review OK?

@openjdk
Copy link

openjdk bot commented May 14, 2024

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

@johanvos
Copy link
Collaborator

@johanvos do you also want to review or is Joeri's review OK?

In Joeri I trust :)

@kevinrushforth
Copy link
Member

In Joeri I trust :)

Me, too. :)

Copy link
Collaborator

@tiainen tiainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything built fine.

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk openjdk bot added the ready Ready to be integrated label May 14, 2024
@HimaBinduMeda
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented May 15, 2024

Going to push as commit 581e3a7.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 15, 2024
@openjdk openjdk bot closed this May 15, 2024
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels May 15, 2024
@openjdk
Copy link

openjdk bot commented May 15, 2024

@HimaBinduMeda Pushed as commit 581e3a7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
4 participants