Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nav with updated class name #49

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

nav with updated class name #49

wants to merge 1 commit into from

Conversation

vcfvct
Copy link

@vcfvct vcfvct commented Nov 13, 2018

Github updated the nav class name form .underline-nav-item to UnderlineNav-item, also need to remove the overall nav border color to make it consistent.
dom

before

border-before

after

border-after

@jgkamat
Copy link
Collaborator

jgkamat commented Nov 14, 2018 via email

@alphapapa
Copy link
Owner

Thanks. Should we remove the border color altogether as you have here, or should we add it to the missing spots?

@vcfvct vcfvct closed this Nov 11, 2020
@alphapapa alphapapa reopened this Nov 12, 2020
@alphapapa
Copy link
Owner

@vcfvct Why did you close this PR? Is it still applicable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vcfvct @jgkamat @alphapapa