Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wsrelay connection leak #15113

Merged
merged 1 commit into from Apr 16, 2024
Merged

Fix wsrelay connection leak #15113

merged 1 commit into from Apr 16, 2024
+72 −49

Conversation

TheRealHaoLiu
Copy link
Member

SUMMARY
  • when re-establishing connection to db close old connection
  • re-initialize WebSocketRelayManager when restarting asyncio.run
  • log and ignore error in cleanup_offline_host (this might come back to bite us)
  • cleanup connection when WebSocketRelayManager crash
ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • API
AWX VERSION
ADDITIONAL INFORMATION

@TheRealHaoLiu
Fix wsrelay connection leak
42c0e3a 
- when re-establishing connection to db close old connection
- re-initialize WebSocketRelayManager when restarting asyncio.run
- log and ignore error in cleanup_offline_host (this might come back to bite us)
- cleanup connection when WebSocketRelayManager crash
@TheRealHaoLiu TheRealHaoLiu merged commit e873bb1 into ansible:devel Apr 16, 2024
21 checks passed
@TheRealHaoLiu TheRealHaoLiu deleted the fix-wsrelay-connection-leak branch April 16, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbradberry jbradberry jbradberry approved these changes

@fosterseth fosterseth fosterseth approved these changes

Assignees
No one assigned
Labels
component:api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TheRealHaoLiu @jbradberry @fosterseth