Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for Bit workspace #155

Open
3 tasks done
zkochan opened this issue Apr 28, 2023 · 2 comments
Open
3 tasks done

Adding support for Bit workspace #155

zkochan opened this issue Apr 28, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@zkochan
Copy link

zkochan commented Apr 28, 2023

Clear and concise description of the problem

In a Bit workspace bit install should be executed.

Suggested solution

If there is a workspace.jsonc file in the directory, then run bit install.

Alternative

No response

Additional context

No response

Validations

@zkochan zkochan added the enhancement New feature or request label Apr 28, 2023
@antfu
Copy link
Member

antfu commented Apr 29, 2023

I am open to that, but I got a few questions:

  • Is bit a near 1:1 replacement to the other package manager? (I supposed it's powered by pnpm underneath - would it be the case you need to run other commands from pnpm when using bit or are they all forwarded?)
  • workspace.jsonc sounds like a bit general to me, do you think it's safe to be the detect source?
  • Does it support packageManager field?

My questions are mostly asking if bit can be considered a full "package manager". That said, I am open to PRs. If the support of bit could be close to the existing package managers then sure :)

@zkochan
Copy link
Author

zkochan commented Apr 29, 2023

Is bit a near 1:1 replacement to the other package manager? (I supposed it's powered by pnpm underneath - would it be the case you need to run other commands from pnpm when using bit or are they all forwarded?)

It uses pnpm by default but also supports Yarn. It is not a 1:1 replacement but some commands match. The install command for sure. You cannot use pnpm commands directly in a bit workspace as a bit workspace doesn't have package.json files.

workspace.jsonc sounds like a bit general to me, do you think it's safe to be the detect source?

OK, we can check for .bitmap instead.

Does it support packageManager field?

No, I am not sure if it will. A bit workspace doesn't package.json files at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants