Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]The task flow instance should be displayed as a history after the task flow definition is deleted.(任务流定义被删除后任务流实例应作为历史记录展示) #698

Open
n2-cmd opened this issue Aug 13, 2019 · 1 comment
Labels
feature new feature

Comments

@n2-cmd
Copy link

n2-cmd commented Aug 13, 2019

Is your feature request related to a problem? Please describe.
When I delete the task flow definition, I find that the task flow instance related to it is not queried. This is different from what I expected. I think the task flow instance display also has the role of historical workflow display. It should not be deleted as history records.

Describe the solution you'd like

  1. After the task flow definition is deleted, the executed task flow instance and task instance should be displayed as history.
  2. When the task flow definition is deleted, the executed task flow instance should no longer be able to edit the rerun. Editing a workflow instance is convenient but not well maintained, and is only used when testing changes to the workflow. When the action flow definition is deleted, there should be no more edited rerun scenarios.
  3. Assume that the editing workflow instance is used for task flow debugging. It is recommended that the modified workflow can be automatically applied to the current workflow definition, or a button can be applied to the definition without re-modification in the definition.

Describe alternatives you've considered

  1. I modified the task flow instance edit and edited it to the task flow instance.
  2. I added project_id and is_deleted to tf_process_instance. When the workflow definition is deleted, the workflow instance is marked as deleted. The deleted instance can be displayed but cannot be edited and rerun.

Additional context

@n2-cmd n2-cmd added the feature new feature label Aug 13, 2019
@n2-cmd n2-cmd changed the title [Feature]任务流定义被删除后任务流实例消失 [Feature]The task flow instance should be displayed as a history after the task flow definition is deleted.(任务流定义被删除后任务流实例应作为历史记录展示) Aug 13, 2019
@boandai boandai added this to Requirement(需求) in DolphinScheduler Work Plan via automation Aug 14, 2019
@davidzollo
Copy link
Contributor

very good idea , thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature new feature
Projects
None yet
Development

No branches or pull requests

2 participants