Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Multisig V2] Merged Multisig payload simulation with execution #12705

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

junkil-park
Copy link
Contributor

@junkil-park junkil-park commented Mar 27, 2024

  • Refactored the Multisig payload simulation path, by merging the simulation function with the execution function

This resolves #12703 and #12704.

Description

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Testnet with the localnet

Copy link

trunk-io bot commented Mar 27, 2024

⏱️ 8h 4m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-unit-tests 6h 25m 🟥🟥
windows-build 30m 🟩🟩
rust-move-tests 27m 🟩🟩
rust-lints 11m 🟥🟩
check 8m 🟩🟩
run-tests-main-branch 8m 🟩🟩
check-dynamic-deps 7m 🟩🟩
general-lints 5m 🟩🟩
semgrep/ci 54s 🟩🟩
file_change_determinator 22s 🟩🟩
file_change_determinator 20s 🟩🟩
permission-check 6s 🟩🟩
permission-check 6s 🟩🟩
permission-check 4s 🟩🟩
permission-check 4s 🟩🟩

🚨 2 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
rust-unit-tests 6h 27m +1243%
check-dynamic-deps 5m 2m +148%

settingsfeedbackdocs ⋅ learn more about trunk.io

- Refactored the Multisig payload simulation path, by merging the simulation function with the execution function
@junkil-park junkil-park force-pushed the jpark/multisig-simulation-refactoring branch from e455219 to 260287e Compare March 27, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Multisig V2] Multisig payload simulation fails when no entry function is provided
1 participant