Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[quorum store] fix last commit in #13019 #13208

Merged
merged 1 commit into from
May 6, 2024
Merged

[quorum store] fix last commit in #13019 #13208

merged 1 commit into from
May 6, 2024

Conversation

bchocho
Copy link
Contributor

@bchocho bchocho commented May 6, 2024 •
edited

Description

Accidentally landed #13019 with local changes not committed.

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

All CICD tests

Key Areas to Review

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@trunk-io Trunk.io
Copy link

trunk-io bot commented May 6, 2024 •
edited

⏱️ 7h 10m total CI duration on this PR
Job Cumulative Duration Recent Runs
execution-performance / single-node-performance 1h 12m 🟩 🟥 🟩 
forge-framework-upgrade-test / forge 1h 8m 🟩 
rust-smoke-tests 1h 3m 🟩 🟩 
windows-build 37m 🟩 
forge-e2e-test / forge 32m 🟩 🟩 
forge-compat-test / forge 27m 🟩 🟩 
rust-images / rust-all 26m 🟩 🟩 
rust-targeted-unit-tests 17m ⬜ 🟩 🟩 
rust-lints 15m ⬜ 🟩 🟩 
cli-e2e-tests / run-cli-tests 13m 🟩 🟩 
rust-move-tests 10m ⬜ 🟩 🟩 
run-tests-main-branch 8m 🟩 🟩 
framework-upgrade-determinator 8m 🟩 🟩 
check 8m 🟩 🟩 
rust-build-cached-packages 7m 🟩 🟩 
check-dynamic-deps 4m 🟩 🟩 🟩 
general-lints 4m ⬜ 🟩 🟩 
indexer-grpc-e2e-tests / test-indexer-grpc-docker-compose 3m 🟥 🟩 
node-api-compatibility-tests / node-api-compatibility-tests 2m 🟩 🟩 
semgrep/ci 1m 🟩 🟩 🟩 
file_change_determinator 31s 🟩 🟩 🟩 
file_change_determinator 29s ⬜ 🟩 🟩 
execution-performance / file_change_determinator 22s 🟩 🟩 
file_change_determinator 20s 🟩 🟩 
permission-check 13s 🟩 🟩 🟩 
permission-check 12s 🟩 🟩 🟩 
permission-check 8s 🟩 🟩 🟩 
permission-check 7s 🟩 🟩 🟩 
permission-check 5s 🟩 🟩 
determine-docker-build-metadata 4s 🟩 🟩 

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

@bchocho bchocho added the CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR label May 6, 2024
@bchocho bchocho changed the title fix previous commit [quorum store] fix last commit in #13019 May 6, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@bchocho bchocho marked this pull request as ready for review May 6, 2024 18:37
@bchocho bchocho requested review from sasha8 and gelash as code owners May 6, 2024 18:37
@bchocho bchocho enabled auto-merge (squash) May 6, 2024 21:40
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2024

✅ Forge suite compat success on 01b24e7e3548382dd25440b39a0438a993387f12 ==> 43aeb1ea9b02040886048834f83f7ab79abfd5ed

Compatibility test results for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 43aeb1ea9b02040886048834f83f7ab79abfd5ed (PR)
1. Check liveness of validators at old version: 01b24e7e3548382dd25440b39a0438a993387f12
compatibility::simple-validator-upgrade::liveness-check : committed: 6514 txn/s, latency: 5093 ms, (p50: 4800 ms, p90: 8900 ms, p99: 10100 ms), latency samples: 228020
2. Upgrading first Validator to new version: 43aeb1ea9b02040886048834f83f7ab79abfd5ed
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1728 txn/s, latency: 17321 ms, (p50: 19000 ms, p90: 24400 ms, p99: 24700 ms), latency samples: 93320
3. Upgrading rest of first batch to new version: 43aeb1ea9b02040886048834f83f7ab79abfd5ed
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1648 txn/s, latency: 17185 ms, (p50: 19500 ms, p90: 22300 ms, p99: 22800 ms), latency samples: 85720
4. upgrading second batch to new version: 43aeb1ea9b02040886048834f83f7ab79abfd5ed
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3622 txn/s, latency: 8867 ms, (p50: 9600 ms, p90: 12600 ms, p99: 12700 ms), latency samples: 144880
5. check swarm health
Compatibility test for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 43aeb1ea9b02040886048834f83f7ab79abfd5ed passed
Test Ok

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2024

✅ Forge suite realistic_env_max_load success on 43aeb1ea9b02040886048834f83f7ab79abfd5ed

two traffics test: inner traffic : committed: 7320 txn/s, latency: 5362 ms, (p50: 5100 ms, p90: 6200 ms, p99: 12200 ms), latency samples: 3162560
two traffics test : committed: 100 txn/s, latency: 2085 ms, (p50: 2000 ms, p90: 2300 ms, p99: 6900 ms), latency samples: 1800
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.205, avg: 0.204", "QsPosToProposal: max: 0.280, avg: 0.256", "ConsensusProposalToOrdered: max: 0.472, avg: 0.444", "ConsensusOrderedToCommit: max: 0.395, avg: 0.383", "ConsensusProposalToCommit: max: 0.840, avg: 0.827"]
Max round gap was 1 [limit 4] at version 1525506. Max no progress secs was 4.651746 [limit 15] at version 1525506.
Test Ok

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2024

✅ Forge suite framework_upgrade success on 01b24e7e3548382dd25440b39a0438a993387f12 ==> 43aeb1ea9b02040886048834f83f7ab79abfd5ed

Compatibility test results for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 43aeb1ea9b02040886048834f83f7ab79abfd5ed (PR)
Upgrade the nodes to version: 43aeb1ea9b02040886048834f83f7ab79abfd5ed
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1368 txn/s, submitted: 1370 txn/s, failed submission: 1 txn/s, expired: 1 txn/s, latency: 2373 ms, (p50: 2100 ms, p90: 3900 ms, p99: 5400 ms), latency samples: 113620
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1219 txn/s, submitted: 1222 txn/s, failed submission: 3 txn/s, expired: 3 txn/s, latency: 2533 ms, (p50: 1800 ms, p90: 4700 ms, p99: 8100 ms), latency samples: 108500
5. check swarm health
Compatibility test for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 43aeb1ea9b02040886048834f83f7ab79abfd5ed passed
Upgrade the remaining nodes to version: 43aeb1ea9b02040886048834f83f7ab79abfd5ed
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1189 txn/s, submitted: 1193 txn/s, failed submission: 3 txn/s, expired: 3 txn/s, latency: 2518 ms, (p50: 2100 ms, p90: 4400 ms, p99: 6800 ms), latency samples: 105900
Test Ok

@bchocho bchocho merged commit 9eece25 into main May 6, 2024
142 of 149 checks passed
@bchocho bchocho deleted the brian/hash-filter-also-remote-2 branch May 6, 2024 23:02
georgemitenkov pushed a commit that referenced this pull request May 15, 2024
@bchocho @georgemitenkov
[quorum store] fix last commit in #13019 (#13208)
0bc8352 
## Description
Accidentally landed #13019 with local changes not committed.

## How Has This Been Tested?
All CICD tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sitalkedia sitalkedia sitalkedia approved these changes

@zekun000 zekun000 zekun000 approved these changes

@sasha8 sasha8 Awaiting requested review from sasha8 sasha8 is a code owner

@gelash gelash Awaiting requested review from gelash gelash is a code owner

Assignees
No one assigned
Labels
CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bchocho @sitalkedia @zekun000