Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validate 3 #13217

Closed
wants to merge 1 commit into from
Closed

validate 3 #13217

wants to merge 1 commit into from

Conversation

zjma
Copy link
Contributor

@zjma zjma commented May 6, 2024

Description

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@trunk-io Trunk.io
Copy link

trunk-io bot commented May 6, 2024 •
edited

⏱️ 2h 37m total CI duration on this PR
Job Cumulative Duration Recent Runs
forge-framework-upgrade-test / forge 1h 7m 🟩 
rust-unit-tests 31m ⬜ 🟩 
rust-move-tests 19m ⬜ 🟩 
rust-images / rust-all 17m 🟩 
rust-lints 11m ⬜ 🟩 
run-tests-main-branch 4m 🟩 
check-dynamic-deps 3m 🟩 🟩 
general-lints 2m ⬜ 🟩 
semgrep/ci 53s 🟩 🟩 
file_change_determinator 29s 🟩 🟩 
file_change_determinator 29s 🟩 🟩 
file_change_determinator 28s 🟩 🟩 
file_change_determinator 16s 🟩 
permission-check 10s 🟩 🟩 
permission-check 6s 🟩 🟩 
permission-check 5s 🟩 🟩 
permission-check 4s 🟩 🟩 
permission-check 3s 🟩 
determine-docker-build-metadata 3s 🟩 

🚨 3 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
rust-move-tests 19m 8m +125%
rust-lints 10m 6m +71%
rust-images / rust-all 17m 13m +27%

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 7, 2024

✅ Forge suite framework_upgrade success on b68b5ec77776345912ff684fa0e614a832b5e584 ==> 25e8b7a1fa1790d3bbb0bc881d266a4829a0af20

Compatibility test results for b68b5ec77776345912ff684fa0e614a832b5e584 ==> 25e8b7a1fa1790d3bbb0bc881d266a4829a0af20 (PR)
Upgrade the nodes to version: 25e8b7a1fa1790d3bbb0bc881d266a4829a0af20
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 6904 txn/s, latency: 4808 ms, (p50: 4800 ms, p90: 7800 ms, p99: 8400 ms), latency samples: 241640
5. check swarm health
Compatibility test for b68b5ec77776345912ff684fa0e614a832b5e584 ==> 25e8b7a1fa1790d3bbb0bc881d266a4829a0af20 passed
Test Ok

@zjma zjma closed this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidiw davidiw Awaiting requested review from davidiw davidiw will be requested when the pull request is marked ready for review davidiw is a code owner

@wrwg wrwg Awaiting requested review from wrwg wrwg will be requested when the pull request is marked ready for review wrwg is a code owner

@zekun000 zekun000 Awaiting requested review from zekun000 zekun000 will be requested when the pull request is marked ready for review zekun000 is a code owner

@vgao1996 vgao1996 Awaiting requested review from vgao1996 vgao1996 will be requested when the pull request is marked ready for review vgao1996 is a code owner

@georgemitenkov georgemitenkov Awaiting requested review from georgemitenkov georgemitenkov will be requested when the pull request is marked ready for review georgemitenkov is a code owner

Assignees
No one assigned
Labels
CICD:run-framework-upgrade-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@zjma