Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gas] revert unintended change to max_transaction_size_in_bytes (1.12) #13210

Merged

Conversation

vgao1996
Copy link
Contributor

@vgao1996 vgao1996 commented May 6, 2024

No description provided.

@vgao1996 vgao1996 requested review from zjma and sherry-x May 6, 2024 18:18
@sherry-x sherry-x enabled auto-merge (squash) May 6, 2024 19:38
@vgao1996 vgao1996 changed the title [gas] remove unintended change to max_transaction_size_in_bytes (1.12) [gas] revert unintended change to max_transaction_size_in_bytes (1.12) May 6, 2024

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented May 6, 2024

✅ Forge suite compat success on 01b24e7e3548382dd25440b39a0438a993387f12 ==> a59e8d4323d16706fbaca41e00f5f6200fb12de3

Compatibility test results for 01b24e7e3548382dd25440b39a0438a993387f12 ==> a59e8d4323d16706fbaca41e00f5f6200fb12de3 (PR)
1. Check liveness of validators at old version: 01b24e7e3548382dd25440b39a0438a993387f12
compatibility::simple-validator-upgrade::liveness-check : committed: 6230 txn/s, latency: 5135 ms, (p50: 4800 ms, p90: 9300 ms, p99: 11100 ms), latency samples: 249200
2. Upgrading first Validator to new version: a59e8d4323d16706fbaca41e00f5f6200fb12de3
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1676 txn/s, latency: 16345 ms, (p50: 19100 ms, p90: 23200 ms, p99: 25000 ms), latency samples: 90540
3. Upgrading rest of first batch to new version: a59e8d4323d16706fbaca41e00f5f6200fb12de3
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1408 txn/s, latency: 20302 ms, (p50: 23100 ms, p90: 27800 ms, p99: 29500 ms), latency samples: 76080
4. upgrading second batch to new version: a59e8d4323d16706fbaca41e00f5f6200fb12de3
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3693 txn/s, latency: 8669 ms, (p50: 9900 ms, p90: 12100 ms, p99: 12500 ms), latency samples: 144040
5. check swarm health
Compatibility test for 01b24e7e3548382dd25440b39a0438a993387f12 ==> a59e8d4323d16706fbaca41e00f5f6200fb12de3 passed
Test Ok

Copy link
Contributor

github-actions bot commented May 6, 2024

✅ Forge suite realistic_env_max_load success on a59e8d4323d16706fbaca41e00f5f6200fb12de3

two traffics test: inner traffic : committed: 7925 txn/s, latency: 4957 ms, (p50: 4800 ms, p90: 5700 ms, p99: 10500 ms), latency samples: 3415900
two traffics test : committed: 100 txn/s, latency: 1892 ms, (p50: 1900 ms, p90: 2100 ms, p99: 3400 ms), latency samples: 1780
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.208, avg: 0.203", "QsPosToProposal: max: 0.309, avg: 0.235", "ConsensusProposalToOrdered: max: 0.451, avg: 0.424", "ConsensusOrderedToCommit: max: 0.405, avg: 0.382", "ConsensusProposalToCommit: max: 0.849, avg: 0.806"]
Max round gap was 1 [limit 4] at version 1764047. Max no progress secs was 4.766298 [limit 15] at version 1764047.
Test Ok

@sherry-x sherry-x merged commit abe62d1 into aptos-labs:aptos-release-v1.12 May 6, 2024
94 of 96 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants