Avoid reporting balenarc parsing errors #2094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdcastro
reviewed
Nov 11, 2020
lib/errors.ts
Outdated
| @@ -156,6 +156,7 @@ const EXPECTED_ERROR_REGEXES = [ | |||
| /must also be provided when using/, // oclif parser (depends-on) | |||
| /^Expected an integer/, // oclif parser (flags.integer) | |||
| /^Flag .* expects a value/, // oclif parser | |||
| /^Error parsing config file.*.balenarc.yml/, | |||
There was a problem hiding this comment.
The two dots in the substring .balenarc.yml are interpreted in the regex sense of "any character" and I guess this was not intentional, although it works. Note that:
- The homedir configuration file is named
_balenarc.ymlon Windows and.balenarc.ymlon Linux/macOS. - A file named
balenarc.yml(without a_or.as prefixes) on the current working directory takes precedence over the homedir configuration file (documentation).
The regex works anyway because .*. means the same as .*, but I think it would be more... "canonical" to write:
/^Error parsing config file.*balenarc\.yml/,
Change-type: patch Connects-to: #1100 Signed-off-by: Scott Lowe <scott@balena.io>
98f06a4
to
1b0c14f
Compare
pdcastro
approved these changes
Nov 11, 2020
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-type: patch
Connects-to: #1100
Signed-off-by: Scott Lowe scott@balena.io