Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --view flag to fleet command for opening a fleet's dashboard page #2496

Merged
1 commit merged into from
Jul 7, 2022

Conversation

myarmolinsky
Copy link
Member

Add --view flag to fleet command for opening a fleet's dashboard page

Connects-to: #1440
Change-type: minor
Signed-off-by: Matthew Yarmolinsky matthew-timothy@balena.io


Please check the CONTRIBUTING.md file for relevant information and some
guidance. Keep in mind that the CLI is a cross-platform application that runs
on Windows, macOS and Linux. Tests will be automatically run by balena CI on
all three operating systems, but this will only help if you have added test
code that exercises the modified or added feature code.

Note that each commit message (currently only the first line) will be
automatically copied to the CHANGELOG.md file, so try writing it in a way
that describes the feature or fix for CLI users.

If there isn't a linked issue or if the linked issue doesn't quite match the
PR, please add a PR description to explain its purpose or the features that it
implements. Adding PR comments to blocks of code that aren't self explanatory
usually helps with the review process.

If the PR introduces security considerations or affects the development, build
or release process, please be sure to highlight this in the PR description.

Thank you very much for your contribution!

Copy link
Member

@thgreasi thgreasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure whether this has been discussed but LGTM 👍

lib/commands/fleet/index.ts Outdated Show resolved Hide resolved
…page

Change-type: minor
Signed-off-by: Matthew Yarmolinsky <matthew-timothy@balena.io>
@ghost
Copy link

ghost commented Jul 5, 2022

The preview site has been deleted.

@thgreasi
Copy link
Member

thgreasi commented Jul 7, 2022

@balena-ci retest

@ghost ghost merged commit be7c0dc into master Jul 7, 2022
@ghost ghost deleted the add-fleet-view-command branch July 7, 2022 07:58
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants