fix(sdk): load usbboot adapter on start #2296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lurch
reviewed
Jun 12, 2018
lib/sdk/adapters/index.js
Outdated
| // to open USB devices. | ||
| if (os.platform() !== 'linux') { | ||
| // On GNU/Linux, we only support usbboot when running as root. | ||
| if ((os.platform() !== 'linux') || (process.geteuid() === permissions.UNIX_SUPERUSER_USER_ID)) { |
There was a problem hiding this comment.
Isn't this duplicating the functionality already contained inside permissions.isElevated() ? Or are you doing it this way simply to avoid using Promises?
There was a problem hiding this comment.
We can't use isElevated() here as it returns a promise and we want to set exports now.
04a2532
to
43bb363
Compare
e755567
to
a880d97
Compare
thundron
approved these changes
Aug 6, 2018
a880d97
to
4e28fd8
Compare
Change-type: patch Changelog-entry: Load usbboot adapter on start on GNU/Linux if running as root. Signed-off-by: Alexis Svinartchouk <alexis@resin.io>
4e28fd8
to
26779ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason loading it later didn't work
Change-Type: patch
Changelog-Entry: Load usbboot adapter on start on GNU/Linux if running
as root.