fix(cli): Don't use electron to get USER_DATA_DIR in CLI #2433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4c66723
to
d33bf9e
Compare
|
retest |
|
@resin-ci retest |
d33bf9e
to
00a1b36
Compare
00a1b36
to
64ff5eb
Compare
A previous change erronously relied solely on `electron` to determine the user's data directory, which of course, isn't available when running in the CLI. So this adds a fallback to the same mechanic for CLI should this code not be loaded in Electron. Change-type: patch Signed-off-by: Jonas Hermsmeier <jhermsmeier@gmail.com>
64ff5eb
to
40d84b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous change erroneously relied solely on
electronto determinethe user's data directory, which of course, isn't available when running
in the CLI. So this adds a fallback to the same mechanic for CLI should
this code not be loaded in Electron.
Change-type: patch
Signed-off-by: Jonas Hermsmeier jhermsmeier@gmail.com