New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
patch: introducing github actions (WinGet) #3780
Conversation
The preview site has been deleted. |
@mcraa do we want to do this still? |
@mcraa @builder555 @zwhitchcox this looks like a great first step to automating some more of these: https://en.wikipedia.org/wiki/List_of_software_package_management_systems I would suggest we also consider The ideal place for these steps to live would be in |
@ab77 yes, |
No it does not. it is just a gh token so the action can open a PR for the |
If the token is always the same, we need to store it in a github actions secrets. This way it will be fully protected and only accessible to PRs running in our org (not on forks). Please get the token setup with the ops team in bitwarden and share it with me so I can take of setting up GH secrets. |
i don't know why i remembered wrong but here is the correction: |
@mcraa parameters aren't secure, so passing secrets via these is an anti-pattern IMO. Can we make it a secret please? Also, we need to consider #3853 in the context of package repositories which use PR flow (doesn't scale with auto release cadence). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we please use FLOWZONE existing token here if it will suffice.
patch: introducing github actions
winget release, EP auto update, release build
Change-Type: patch