Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use core workflow for GitHub publish #3868

Merged
merged 1 commit into from Dec 5, 2022
Merged

Use core workflow for GitHub publish #3868

merged 1 commit into from Dec 5, 2022

Conversation

ab77
Copy link
Contributor

@ab77 ab77 commented Nov 9, 2022

Ideally wait for product-os/flowzone#355

Note: switched branches while in flight, comments below relate to another PR.

@resin-jenkins resin-jenkins force-pushed the ab77/operational branch 12 times, most recently from a7e0c14 to 5420891 Compare November 11, 2022 00:28
@theofficialgman
Copy link

theofficialgman commented Nov 15, 2022

fyi you are going to have a bad time with this because there are multiple BAD node packages that put x86_64 binaries inside their arm64 binaries folder and literally call them arm64 binaries... one example is the lzma-native node module does this on all OSs 😢. its been reported for years and still goes unfixed by the dev

you won't realize this is an issue until you actually go to launch etcher and you whitescreen and check the developer console for the log

@ab77
Copy link
Contributor Author

ab77 commented Nov 15, 2022

you won't realize this is an issue until you actually go to launch etcher and you whitescreen and check the developer console for the log

Oh yes - we know, thank you! This is exactly where we are with this PR at the moment... @theofficialgman

@ab77 ab77 changed the title Build and package ARM releases Use core workflow for GitHub publish Dec 1, 2022
@ab77 ab77 force-pushed the ab77/operational branch 3 times, most recently from ba852f9 to 6fea6af Compare December 5, 2022 18:46
@ab77 ab77 marked this pull request as ready for review December 5, 2022 18:51
@ab77
Copy link
Contributor Author

ab77 commented Dec 5, 2022

@balena-ci I self-certify!

@ab77 ab77 merged commit 895c306 into master Dec 5, 2022
@ab77 ab77 deleted the ab77/operational branch December 5, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants