Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes corvus in favor of sentry and analytics client #3891

Merged
merged 6 commits into from Jan 16, 2023

Conversation

otaviojacobi
Copy link
Contributor

Change-type: patch
Signed-off-by: Otavio Jacobi

@otaviojacobi otaviojacobi force-pushed the removes-corvus branch 2 times, most recently from 7a835c3 to a903198 Compare December 2, 2022 17:25
@@ -31,7 +31,7 @@ Releasing
- [Post release note to forums](https://forums.balena.io/c/etcher)
- [Submit Windows binaries to Symantec for whitelisting](#submitting-binaries-to-symantec)
- [Update the website](https://github.com/balena-io/etcher-homepage)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently that repo is now read-only ?

@@ -31,7 +31,7 @@ Releasing
- [Post release note to forums](https://forums.balena.io/c/etcher)
- [Submit Windows binaries to Symantec for whitelisting](#submitting-binaries-to-symantec)
- [Update the website](https://github.com/balena-io/etcher-homepage)
- Wait 2-3 hours for analytics (Sentry, Mixpanel) to trickle in and check for elevated error rates, or regressions
- Wait 2-3 hours for analytics (Sentry, amplitude) to trickle in and check for elevated error rates, or regressions
- If regressions arise; pull the release, and release a patched version, else:
- [Upload deb & rpm packages to Bintray](#uploading-packages-to-bintray)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL, and IIRC you now use Cloudsmith instead of Bintray? 🤷

docs/MAINTAINERS.md Outdated Show resolved Hide resolved
@otaviojacobi otaviojacobi force-pushed the removes-corvus branch 3 times, most recently from d335720 to eb8a9b1 Compare January 4, 2023 13:58
lib/gui/etcher.ts Outdated Show resolved Hide resolved
otaviojacobi and others added 4 commits January 12, 2023 11:11
Change-type: patch
Signed-off-by: Otavio Jacobi
Change-type: patch
Signed-off-by: Otavio Jacobi
@otaviojacobi
Copy link
Contributor Author

@balena-ci rebase

@mcraa
Copy link
Contributor

mcraa commented Jan 12, 2023

the initial log from the console

Thu Jan 12 2023 17:50:52 GMT+0100 (Central European Standard Time) Application start ({"packageType":"nsis","version":"1.13.1","sample":0.1,"applicationSessionUuid":"0a825790-e991-43cd-9338-ac0c71e99737","flashingWorkflowUuid":"e5e69df3-d4a7-4d3a-b6ae-e5ea515d6171"})

is removed, is it still sent to sentry? @otaviojacobi

@otaviojacobi
Copy link
Contributor Author

@mcraa I think you mean if this is still sent to Amplitude, right? AFAIK it is, but it is slightly different now as it does the sampling on our analytics-proxy rather than on etcher itself

@balena-ci balena-ci merged commit 7616c41 into master Jan 16, 2023
@balena-ci balena-ci deleted the removes-corvus branch January 16, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants