New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch: run linux build on ubuntu-18.04 #3893
Conversation
@aethernet looks like more changes are necessary
the ubuntu-toolchain-r ppa includes an updated libgcc1 system package (version 11) package that when installed causes all installed gcc/g++ to produce builds that are not compatible with the default libgcc1 in bionic and focal (version 8 and 10 respectively) idk where that ppa is getting added in the buildsystem but it needs to be removed and is not necessay to build etcher |
@aethernet its not the existance of libgcc1, that is a normal package, its the launchpad ppa that is in the buildsystem that causes the issue where it upgrades that system package the ppa is still there after your latest commit |
mmh i see :( |
Yeah i don't get where it comes from either, maybe it's a dep of something else, or part of the flow, still looking |
The weird thing beeing it happens exactly between the installation of libgbm1 and lbgconf-2.4, ...
The ppa is indeed ubuntu-toolchain-r, but the installation is only for libgcc1 |
it looks to be part of the official github runner image... https://github.com/actions/runner-images/blob/main/images/linux/scripts/installers/gcc.sh thats not good, you could just remove the ppa programatically before any apt installs run, that would solve it I'll look into this again tonight and double check that this is an actual issue. I know for a fact that if you install gcc-11 from that ppa it breaks backwards compatibiility with systems without the ppa, I will need to verify that upgrading libgcc1 is the reason or if it is libgcc-s1 |
why would it install it at that exact moment ? that's very suspicious to me. btw i got confirmation that the build made on ubuntu 18.04 runs fine on unbuntu 20.04. (i won't have a 18.04 avail. tonight but i'll test that tomorrow myself) |
8f2cdf2
to
5620126
Compare
Running on ubuntu-latest means you need a more recent version of glibc which breaks on older ubuntu. Thanks to @theofficialgman for suggesting the fix.
5620126
to
57a6cef
Compare
I confirm it works on 18.04 |
@balena-ci I self-certify! |
Running on ubuntu-latest means you need a more recent version of glibc which breaks on older ubuntu.
Thanks to @theofficialgman for suggesting the fix.