Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch: run linux build on ubuntu-18.04 #3893

Merged
merged 1 commit into from Dec 2, 2022
Merged

Conversation

aethernet
Copy link
Contributor

Running on ubuntu-latest means you need a more recent version of glibc which breaks on older ubuntu.

Thanks to @theofficialgman for suggesting the fix.

@theofficialgman
Copy link

theofficialgman commented Dec 1, 2022

@aethernet looks like more changes are necessary
there is a prolematic PPA added that ends up bumping the glibc requirement higher than bionic.
https://github.com/balena-io/etcher/actions/runs/3593553166/jobs/6050703854#step:5:314

The following packages will be upgraded:
  libgcc1
1 upgraded, 0 newly installed, 0 to remove and 11 not upgraded.
Need to get 41.7 kB of archives.
After this operation, 0 B of additional disk space will be used.
Get:1 http://ppa.launchpad.net/ubuntu-toolchain-r/test/ubuntu bionic/main amd64 libgcc1 amd64 1:11.1.0-1ubuntu1~18.04.1 [41.7 kB]

the ubuntu-toolchain-r ppa includes an updated libgcc1 system package (version 11) package that when installed causes all installed gcc/g++ to produce builds that are not compatible with the default libgcc1 in bionic and focal (version 8 and 10 respectively)

idk where that ppa is getting added in the buildsystem but it needs to be removed and is not necessay to build etcher

@theofficialgman
Copy link

theofficialgman commented Dec 1, 2022

@aethernet its not the existance of libgcc1, that is a normal package, its the launchpad ppa that is in the buildsystem that causes the issue where it upgrades that system package

the ppa is still there after your latest commit
https://github.com/balena-io/etcher/actions/runs/3594586798/jobs/6053071258#step:5:319

@aethernet
Copy link
Contributor Author

mmh i see :(

@aethernet
Copy link
Contributor Author

Yeah i don't get where it comes from either, maybe it's a dep of something else, or part of the flow, still looking

@aethernet
Copy link
Contributor Author

aethernet commented Dec 1, 2022

The weird thing beeing it happens exactly between the installation of libgbm1 and lbgconf-2.4, ...

    - libgbm1
    - libgcc1
    - libgconf-2-4

The ppa is indeed ubuntu-toolchain-r, but the installation is only for libgcc1

@theofficialgman
Copy link

theofficialgman commented Dec 1, 2022

it looks to be part of the official github runner image... https://github.com/actions/runner-images/blob/main/images/linux/scripts/installers/gcc.sh

thats not good, you could just remove the ppa programatically before any apt installs run, that would solve it

I'll look into this again tonight and double check that this is an actual issue. I know for a fact that if you install gcc-11 from that ppa it breaks backwards compatibiility with systems without the ppa, I will need to verify that upgrading libgcc1 is the reason or if it is libgcc-s1

@aethernet
Copy link
Contributor Author

why would it install it at that exact moment ? that's very suspicious to me.

btw i got confirmation that the build made on ubuntu 18.04 runs fine on unbuntu 20.04. (i won't have a 18.04 avail. tonight but i'll test that tomorrow myself)

Running on ubuntu-latest means you need a more recent version of glibc which breaks on older ubuntu.

Thanks to @theofficialgman for suggesting the fix.
@aethernet
Copy link
Contributor Author

I confirm it works on 18.04
I'm rebasing and will retest, but I believe we're good here.

@aethernet
Copy link
Contributor Author

@balena-ci I self-certify!

@aethernet aethernet merged commit ccca009 into master Dec 2, 2022
@aethernet aethernet deleted the aethernet-fix-ubuntu branch December 2, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants