Fix code scanning alert - Type confusion through parameter tampering #1485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: Fix code scanning alert - Type confusion through parameter tampering #1484 Change-type: patch Signed-off-by: Harald Fischer <harald@balena.io>
1 task
Page-
reviewed
Dec 21, 2023
| @@ -9,7 +9,7 @@ const MAX_LOGS_PER_BATCH = 10; | |||
|
|
|||
| export class Supervisor { | |||
| public convertLogs(logs: SupervisorLog[]): DeviceLog[] { | |||
| if (logs.length > MAX_LOGS_PER_BATCH) { | |||
| if (Array.isArray(logs) && logs.length > MAX_LOGS_PER_BATCH) { | |||
There was a problem hiding this comment.
I would prefer this check to be higher up when grabbing req.body rather than nested a couple of levels deep where we would ideally expect the typings to be respected
|
Also I'd prefer a better commit message/changelog entry that mentions what the aim is now, eg that we're improving validation of logs sent to the store endpoint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: Fix code scanning alert - Type confusion through parameter tampering #1484
Change-type: patch