Invalidate smb:// URLs #1631
#1957
Open
+198
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why was Vorta freezing in the fist case? Is there no simpler solution to fixing that? This PR introduces quite some lines of code that need to be maintained. Additionally you do not have the copyright for these lines so proper attribution and license compatibility have to be checked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added logic from borg that validates the url against certain regex patterns. Borg code wont invalidate
smb://urls, so introduced change to one of the regex patternsRelated Issue
#1631
Motivation and Context
Additional check for Repository URL, as using
smb://format resulted in crashes as per #1628How Has This Been Tested?
using
smb://repository URLs gave an error like other unsupported onesScreenshots (if appropriate):
Types of changes
Checklist:
I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.