Added option to skip subscriber verification #1993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * | ||
| * @var \Illuminate\Contracts\Config\Repository | ||
| */ | ||
| protected $config; |
There was a problem hiding this comment.
We should never need to read config from inside handlers.
|
I think we can do this at the controller, just use the config here https://github.com/CachetHQ/Cachet/blob/2.3/app/Http/Controllers/SubscribeController.php#L61 what do you think? |
[ci skip] [skip ci]
|
Also, this implementation was broken with the API before. :P |
|
This is not pretty, but I think a bit better now. What do you think? |
|
@jbrooksuk or @joecohens merge if you're happy with this. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1990
Ping @joecohens