Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendly & SavvyCal import #1512

Merged
merged 11 commits into from
Jan 15, 2022
Merged

Calendly & SavvyCal import #1512

merged 11 commits into from
Jan 15, 2022

Conversation

baileypumfleet
Copy link
Contributor

@baileypumfleet baileypumfleet commented Jan 14, 2022

This adds two buttons to the onboarding flow where you can choose which platform you'd like to import from, and runs two API queries to either API to get the user data and update the user with it, and the other API query gets your event types and creates them on our end.

Our goal is to make scheduling as open and accessible as possible and this helps customers make the right choice by not feeling locked in by other products.

@vercel
Copy link

vercel bot commented Jan 14, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/cal/calendso/8uovf1nMMobzCJwSopweAxuDDYS7
✅ Preview: https://calendso-git-import-cal.vercel.app

pages/getting-started.tsx Outdated Show resolved Hide resolved
pages/getting-started.tsx Outdated Show resolved Hide resolved
pages/getting-started.tsx Outdated Show resolved Hide resolved
@PeerRich
Copy link
Member

very nice! can you add some description how to test this properly? maybe set up some test accounts too as I believe there is no way to retrigger the onboarding.

@vercel vercel bot temporarily deployed to Preview January 14, 2022 18:04 Inactive
Copy link
Member

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, some screenshots would be nice tho :)

pages/getting-started.tsx Outdated Show resolved Hide resolved
pages/api/import/savvycal.ts Outdated Show resolved Hide resolved
pages/api/import/savvycal.ts Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview January 14, 2022 18:45 Inactive
@edanfesi edanfesi self-requested a review January 14, 2022 19:10
@edanfesi
Copy link
Contributor

It looks good to me 🎉

Copy link
Contributor

@edanfesi edanfesi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to change to strict comparison but the rest is perfect

Co-authored-by: Omar López <zomars@me.com>
@vercel vercel bot temporarily deployed to Preview January 14, 2022 20:17 Inactive
PeerRich and others added 2 commits January 14, 2022 20:17
Co-authored-by: Omar López <zomars@me.com>
Co-authored-by: Omar López <zomars@me.com>
@vercel vercel bot temporarily deployed to Preview January 14, 2022 20:20 Inactive
@vercel vercel bot temporarily deployed to Preview January 14, 2022 20:25 Inactive
@vercel vercel bot temporarily deployed to Preview January 14, 2022 20:42 Inactive
@vercel vercel bot temporarily deployed to Preview January 15, 2022 15:35 Inactive
@vercel vercel bot temporarily deployed to Preview January 15, 2022 16:02 Inactive
@PeerRich PeerRich enabled auto-merge (squash) January 15, 2022 16:17
@PeerRich PeerRich merged commit 3369419 into main Jan 15, 2022
@PeerRich PeerRich deleted the import branch January 15, 2022 16:23
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants