Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show dialog only for InPerson and Link locations #2206

Merged
merged 3 commits into from
Mar 21, 2022

Conversation

miguelnietoa
Copy link
Contributor

What does this PR do?

Fixes #1716

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Enter to edit an event type
  • Set a location i.e JitsiMeet and notice the modal is not shown

Demo:
https://app.birdeatsbug.com/sessions/Pnue5mPSURmD2tItO_dBi

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't performed a self-review of my own code and corrected any misspellings
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@vercel
Copy link

vercel bot commented Mar 18, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

docs – ./apps/docs

🔍 Inspect: https://vercel.com/cal/docs/2bgMFGeb8YWQWF3F4myMHV7MShHC
✅ Preview: Canceled

[Deployment for 46b0e69 canceled]

calendso – ./apps/web

🔍 Inspect: https://vercel.com/cal/calendso/9j5fJMkCXNu8zu6bd2N8oNBDc1oi
✅ Preview: https://calendso-git-fork-kommitters-remove-dialog-for-non-i-316aef-cal.vercel.app

@vercel vercel bot temporarily deployed to Preview – docs March 18, 2022 17:12 Inactive
@vercel
Copy link

vercel bot commented Mar 18, 2022

@miguelnietoa is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@vercel vercel bot temporarily deployed to Preview – calendso March 18, 2022 20:28 Inactive
@PeerRich
Copy link
Member

PeerRich commented Mar 18, 2022

hey @miguelnietoa can you allow us to update the branch on behalf of you?
https://github.com/calcom/cal.com/blob/main/CONTRIBUTING.md#making-a-pull-request

@miguelnietoa
Copy link
Contributor Author

Hi @PeerRich, that option is not available since this branch is under a repository forked by an organization.
If you want, provide the usernames of each maintainer to give you all individual access because we don't find a way to give permissions to all the Calendso team.

@PeerRich
Copy link
Member

Hi @PeerRich, that option is not available since this branch is under a repository forked by an organization.

If you want, provide the usernames of each maintainer to give you all individual access because we don't find a way to give permissions to all the Calendso team.

yeah lemme create a contributor team and invite you

@PeerRich
Copy link
Member

PeerRich commented Mar 21, 2022

@miguelnietoa added you to https://github.com/orgs/calcom/teams/contributors/members let me know if I should add more people of your organisation

@miguelnietoa
Copy link
Contributor Author

Thanks for inviting me, I already accepted, so what's next? 🤔

@vercel vercel bot temporarily deployed to Preview – docs March 21, 2022 13:00 Inactive
@vercel vercel bot temporarily deployed to Preview – calendso March 21, 2022 18:49 Inactive
@PeerRich
Copy link
Member

Thanks for inviting me, I already accepted, so what's next? 🤔

awesome welcome to the community contributor team

@sean-brydon can review

@miguelnietoa
Copy link
Contributor Author

Thanks a lot!!! @PeerRich ✔️

Copy link
Member

@PeerRich PeerRich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and works

@PeerRich
Copy link
Member

image

can you update again? alternatively you can close the PR and reopen it so it's being opened as a team member

Copy link
Member

@sean-brydon sean-brydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works - Nice approach i like it :)

@vercel vercel bot temporarily deployed to Preview – docs March 21, 2022 19:16 Inactive
@miguelnietoa
Copy link
Contributor Author

image

can you update again? alternatively you can close the PR and reopen it so it's being opened as a team member

Updated. I will keep it in mind for next PRs 👍🏻

@vercel vercel bot temporarily deployed to Preview – calendso March 21, 2022 20:45 Inactive
@PeerRich PeerRich merged commit 6ed9459 into calcom:main Mar 21, 2022
@PeerRich
Copy link
Member

reviewed, tested and merged! thank you @miguelnietoa

@miguelnietoa miguelnietoa deleted the remove-dialog-for-non-in-person branch March 21, 2022 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove "edit location" dialog for non-in-person
3 participants