Bug - link not showing #2333
Merged
Bug - link not showing #2333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). docs – ./apps/docs🔍 Inspect: https://vercel.com/cal/docs/HwqyNzaMmtzo3gD4W6nF8vwYwskb [Deployment for f0d1bb1 canceled] calendso – ./apps/web🔍 Inspect: https://vercel.com/cal/calendso/2z3nBLZrZsGhUVmyYY7Lt7ZbStUQ |
alannnc
approved these changes
Mar 31, 2022
alannnc
reviewed
Mar 31, 2022
There was a problem hiding this comment.
I updated the PR, as to me link was missing on organiser and attendee emails.
Take a look at my fix and if it doesn't break anything else.
@sean-brydon
e3c1cd5
zomars
reviewed
Mar 31, 2022
| // If location its a url, probably we should be validating it with a custom library | ||
| if ( | ||
| this.calEvent.location && | ||
| (this.calEvent.location.includes("https://") || this.calEvent.location.includes("http://")) |
There was a problem hiding this comment.
This will return true for URLs like: notanUrlButHashttps://intheMiddle
zomars
approved these changes
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes meeting link not showing up in the location field on emails and calendar
Fixes # (issue)
#2332
Type of change
How should this be tested?
Checklist