Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes locations options mistranslations #2336

Merged
merged 2 commits into from
Mar 31, 2022
Merged

Fixes locations options mistranslations #2336

merged 2 commits into from
Mar 31, 2022

Conversation

zomars
Copy link
Member

@zomars zomars commented Mar 31, 2022 •
edited

What does this PR do?

  • Renders locations options and translates them from the server.
  • Cleans up deprecated code since App Store launch

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Edit an event type and see the location options
  • Change the language for the account and see the translated location options

Checklist

  • I haven't performed a self-review of my own code and corrected any misspellings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@vercel
Copy link

vercel bot commented Mar 31, 2022 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

docs – ./apps/docs

🔍 Inspect: https://vercel.com/cal/docs/425iBqEjw3bVG8FfGMdHFVEjopmw
✅ Preview: Canceled

[Deployment for ad77aaf canceled]

calendso – ./apps/web

🔍 Inspect: https://vercel.com/cal/calendso/HyEqSEVbJcjtjTqb1z16tKCRTXEK
✅ Preview: https://calendso-git-fix-location-options-cal.vercel.app

@zomars zomars requested review from a team, natelindev and mihaic195 and removed request for a team and natelindev March 31, 2022 21:12
@vercel vercel bot temporarily deployed to Preview – docs March 31, 2022 21:13 Inactive
@vercel vercel bot temporarily deployed to Preview – calendso March 31, 2022 21:13 Inactive
@zomars zomars added ♻️ autoupdate tells kodiak to keep this branch up-to-date automerge labels Mar 31, 2022
@zomars zomars merged commit f71c0dd into main Mar 31, 2022
@zomars zomars deleted the fix/location-options branch March 31, 2022 21:29
joeauyeung added a commit that referenced this pull request Apr 6, 2022
@joeauyeung
Revert "Fixes locations options mistranslations (#2336)"
e9694b7 
This reverts commit f71c0dd.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaic195 mihaic195 Awaiting requested review from mihaic195

Assignees
No one assigned
Labels
automerge ♻️ autoupdate tells kodiak to keep this branch up-to-date
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@zomars