Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make McFly history.db path configurable #243

Open
praveenperera opened this issue Mar 8, 2022 · 16 comments
Open

Make McFly history.db path configurable #243

praveenperera opened this issue Mar 8, 2022 · 16 comments

Comments

@praveenperera
Copy link
Collaborator

Hey @cantino would you accept a PR to make the Settings::storage_dir_path() configurable with an ENV var?

@cantino
Copy link
Owner

cantino commented Mar 8, 2022

Yup!

@cantino
Copy link
Owner

cantino commented Mar 8, 2022

Actually #124 does this, but I've been dragging my feet since ~/.mcfly seems like a good default to me.

@cantino
Copy link
Owner

cantino commented Mar 8, 2022

But I'd definitely be fine with making it configurable.

@praveenperera
Copy link
Collaborator Author

praveenperera commented Mar 8, 2022

Ya I like ~/.mcfly as a default. But having it overridable if the env var exists.

How about $MCFLY_DB_DIR

@cantino
Copy link
Owner

cantino commented Mar 17, 2022

@praveenperera I think I'm going to accept #124, given the community pressure. Any thoughts?

@praveenperera
Copy link
Collaborator Author

praveenperera commented Mar 19, 2022

@cantino ya that sounds reasonable. Sorry I haven't been able to look at the PRs yet. But I'm assuming it's only changing the default if .mcfly dir doesn't already exist?

Personally though I've never liked having files in ~/Library/Application Support/ just seems harder to access. I always wondered why Mac data dir isn't in the same place as the linux one.

@rpdelaney
Copy link

I suggest following the freedesktop.org XDG base directory specification rather than defaulting ~/.mcfly. This solves all platform interoperability issues cleanly.

@praveenperera
Copy link
Collaborator Author

praveenperera commented Mar 24, 2022

Closed by: #244

@utkarshgupta137
Copy link
Contributor

This issue is still not fixed on macOS.

@cantino
Copy link
Owner

cantino commented Mar 31, 2023

What issue @utkarshgupta137 ?

@utkarshgupta137
Copy link
Contributor

The path is not configurable on macOS. The XDG_DATA_HOME/XDG_CACHE_HOME is only respected on Linux, not macOS or Windows.

@cantino cantino reopened this Apr 1, 2023
@utkarshgupta137
Copy link
Contributor

@cantino Are you working on a fix? Or would you accept a PR? If so, should I just replace the locations?

@cantino
Copy link
Owner

cantino commented Apr 16, 2023

I am not, a PR would be welcome.

@o6uoq
Copy link

o6uoq commented Apr 22, 2024

#349 has been open since April 2023. Any updates on this configuration being baked into McFly?

@praveenperera
Copy link
Collaborator Author

@o6uoq Closed by: #244

@utkarshgupta137
Copy link
Contributor

I don't think the problem is solved by that PR, since history.db is stored along with configuration. Also, there is no configurability on macOS, since XDG is not respected currently.

@cantino cantino reopened this Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants