-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make McFly history.db path configurable #243
Comments
Yup! |
Actually #124 does this, but I've been dragging my feet since |
But I'd definitely be fine with making it configurable. |
Ya I like How about |
@praveenperera I think I'm going to accept #124, given the community pressure. Any thoughts? |
@cantino ya that sounds reasonable. Sorry I haven't been able to look at the PRs yet. But I'm assuming it's only changing the default if Personally though I've never liked having files in |
I suggest following the freedesktop.org XDG base directory specification rather than defaulting |
Closed by: #244 |
This issue is still not fixed on macOS. |
What issue @utkarshgupta137 ? |
The path is not configurable on macOS. The |
@cantino Are you working on a fix? Or would you accept a PR? If so, should I just replace the locations? |
I am not, a PR would be welcome. |
#349 has been open since April 2023. Any updates on this configuration being baked into McFly? |
I don't think the problem is solved by that PR, since history.db is stored along with configuration. Also, there is no configurability on macOS, since XDG is not respected currently. |
Hey @cantino would you accept a PR to make the
Settings::storage_dir_path()
configurable with an ENV var?The text was updated successfully, but these errors were encountered: