Use $XDG_STATE_HOME to store history.db
#349
Conversation
utkarshgupta137
force-pushed
the
master
branch
3 times, most recently
from
0ef76d1
to
184985c
Compare
| let cache_dir = Settings::mcfly_xdg_dir().cache_dir().to_path_buf(); | ||
|
|
||
| Settings::mcfly_base_path(cache_dir).join(PathBuf::from("training-cache.v1.csv")) | ||
| Settings::xdg_base_strategy() |
There was a problem hiding this comment.
What is the difference between mcfly_xdg_dir and xdg_base_strategy?
There was a problem hiding this comment.
I could reuse the name if you want.
There was a problem hiding this comment.
I just didn't understand what the difference is between them.
There was a problem hiding this comment.
mcfly_xdg_dir returned a ProjectDirs from the directories crate. xdg_base_strategy base directory returns an Xdg struct from etcetera crate which is the counterpart to it.
src/settings.rs
Outdated
| @@ -355,35 +356,51 @@ impl Settings { | |||
| settings | |||
| } | |||
|
|
|||
| // Use ~/.mcfly only if it already exists, otherwise create 'mcfly' folder in XDG_CACHE_DIR | |||
| // Use or create the 'mcfly' folder in `$XDG_CACHE_DIR`` | |||
src/settings.rs
Outdated
|
|
||
| fn mcfly_xdg_dir() -> ProjectDirs { | ||
| ProjectDirs::from("", "", "McFly").unwrap() | ||
| let path = Settings::xdg_base_strategy() |
There was a problem hiding this comment.
Sorry, forgot to migrate from data_dir, that's done now.
utkarshgupta137
force-pushed
the
master
branch
3 times, most recently
from
5204e32
to
cff3dc4
Compare
|
@cantino ping |
| @@ -341,7 +341,10 @@ Note that only single-character-prompts are allowed. setting `MCFLY_PROMPT` to ` | |||
|
|
|||
| ### Database Location | |||
|
|
|||
| McFly stores its SQLite database in the standard location for the OS. On OS X, this is in `~/Library/Application Support/McFly` and on Linux it is in `$XDG_DATA_DIR/mcfly/history.db` (default would be `~/.local/share/mcfly/history.db`). For legacy support, if `~/.mcfly/` exists, it is used instead. | |||
There was a problem hiding this comment.
I think instead of migrating, it should keep using the old location if it exists.
|
This PR has been open since April 2023 - is there an update if this is still going to be baked into McFly? |
|
Closed by: #244 |
Fixes #243 #269.