cli: rename flags to options
#7170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dffad7e
to
a607434
Compare
I would think you'd flip this, i.e., base the other one off of this one. That's because this one is much simpler to review and approve. The other one has room for interpretation and requires more discussion. |
helderco
reviewed
Apr 24, 2024
1. Rename all the flag mentions to "options", as proposed by Helder in dagger#7107 (comment) 2. Remove the automatic [flags] append on all commands: dagger#7107 (comment) 3. Set DisableFlagsInUseLine to true for AppendedSubcommands in dagger call Signed-off-by: grouville <guillaume@dagger.io>
a607434
to
c649ae5
Compare
added 2 commits
April 24, 2024 15:33
- Remove the COMMAND copy-paste error, where a command is not required for the watch command - Do not show the [options], as only inherited flags are shown Signed-off-by: grouville <guillaume@dagger.io>
Do not show [options] for command with only inherited flags Signed-off-by: grouville <guillaume@dagger.io>
e1ba4b8
to
99fa95c
Compare
…ands Applies the recommendations from Helder on those sub commands Signed-off-by: grouville <guillaume@dagger.io>
vikram-dagger
pushed a commit
to vikram-dagger/dagger
that referenced
this pull request
May 3, 2024
* cli: rename flags to options 1. Rename all the flag mentions to "options", as proposed by Helder in dagger#7107 (comment) 2. Remove the automatic [flags] append on all commands: dagger#7107 (comment) 3. Set DisableFlagsInUseLine to true for AppendedSubcommands in dagger call Signed-off-by: grouville <guillaume@dagger.io> * cli: fix usage of watch command - Remove the COMMAND copy-paste error, where a command is not required for the watch command - Do not show the [options], as only inherited flags are shown Signed-off-by: grouville <guillaume@dagger.io> * cli: remove [options] for dagger version Do not show [options] for command with only inherited flags Signed-off-by: grouville <guillaume@dagger.io> * cli: fix and add <pattern>... to config views add / set / remove commands Applies the recommendations from Helder on those sub commands Signed-off-by: grouville <guillaume@dagger.io> --------- Signed-off-by: grouville <guillaume@dagger.io>
vikram-dagger
pushed a commit
to vikram-dagger/dagger
that referenced
this pull request
May 3, 2024
* cli: rename flags to options 1. Rename all the flag mentions to "options", as proposed by Helder in dagger#7107 (comment) 2. Remove the automatic [flags] append on all commands: dagger#7107 (comment) 3. Set DisableFlagsInUseLine to true for AppendedSubcommands in dagger call Signed-off-by: grouville <guillaume@dagger.io> * cli: fix usage of watch command - Remove the COMMAND copy-paste error, where a command is not required for the watch command - Do not show the [options], as only inherited flags are shown Signed-off-by: grouville <guillaume@dagger.io> * cli: remove [options] for dagger version Do not show [options] for command with only inherited flags Signed-off-by: grouville <guillaume@dagger.io> * cli: fix and add <pattern>... to config views add / set / remove commands Applies the recommendations from Helder on those sub commands Signed-off-by: grouville <guillaume@dagger.io> --------- Signed-off-by: grouville <guillaume@dagger.io>
vikram-dagger
pushed a commit
to vikram-dagger/dagger
that referenced
this pull request
May 3, 2024
* cli: rename flags to options 1. Rename all the flag mentions to "options", as proposed by Helder in dagger#7107 (comment) 2. Remove the automatic [flags] append on all commands: dagger#7107 (comment) 3. Set DisableFlagsInUseLine to true for AppendedSubcommands in dagger call Signed-off-by: grouville <guillaume@dagger.io> * cli: fix usage of watch command - Remove the COMMAND copy-paste error, where a command is not required for the watch command - Do not show the [options], as only inherited flags are shown Signed-off-by: grouville <guillaume@dagger.io> * cli: remove [options] for dagger version Do not show [options] for command with only inherited flags Signed-off-by: grouville <guillaume@dagger.io> * cli: fix and add <pattern>... to config views add / set / remove commands Applies the recommendations from Helder on those sub commands Signed-off-by: grouville <guillaume@dagger.io> --------- Signed-off-by: grouville <guillaume@dagger.io>
12 tasks
This was referenced May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the action items discussed in #7107 (comment). It is the first one out of 3, discussed with Helder
Branched from #7143, which needs to be merged prior this one.
Update 04/24/2024
<command>in cmd.Use #7143, as Helder suggested<pattern>toaddsubcommand[options]from commands with just global flags.[options]from commands with just global flags)