Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More properties near allof are ignored #697

Open
B-Lorentz opened this issue Jul 28, 2022 · 1 comment · May be fixed by #1415
Open

More properties near allof are ignored #697

B-Lorentz opened this issue Jul 28, 2022 · 1 comment · May be fixed by #1415

Comments

@B-Lorentz
Copy link
Contributor

B-Lorentz commented Jul 28, 2022 •
edited

Using the latest version (v1.11.1-0.20220727161132-874b0a16ac55)
I have a schema like

 x:
      allOf:
      - $ref: '#/components/schemas/y-base'
      properties:
        a:
          ....
        b:
          $ref: '#/components/schemas/b'
      type: object

I get code like:

// X defines model for x.
type X struct {
	// Embedded struct due to allOf(#/components/schemas/y-base)
	YBase `yaml:",inline"`
}

if the old-merge-schemas: true is true, and

// X defines model for x.
type X YBase

when its false, the other properties all ignored
@musaprg
Copy link

musaprg commented Jan 2, 2024

It seems a similar issue has been reported in OpenAPITools/openapi-generator, which normalizes such cases by converting it to allOf-only style. ref

@musaprg musaprg linked a pull request Jan 2, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Respect parent properties in case of merged schemas by allOf musaprg/oapi-codegen
2 participants
@musaprg @B-Lorentz