Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitlab support #9

Open
douglas opened this issue May 9, 2016 · 13 comments
Open

Gitlab support #9

douglas opened this issue May 9, 2016 · 13 comments

Comments

@douglas
Copy link

douglas commented May 9, 2016

Hello,

Congrats for the awesome project! I have been really enjoying using it =)

Also, is there any plans to support Gitlab ? This lib allows this:

https://github.com/gpocentek/python-gitlab

Thanks !

@donnemartin
Copy link
Owner

Thanks Douglas! I haven't used GitLab but have heard good things about it lately. I don't currently have plans on supporting it. Contributions are welcome :)

@douglas
Copy link
Author

douglas commented May 10, 2016

Hello !

I will try to add support for it =)

Thanks for everything, this project is amazing!

@donnemartin
Copy link
Owner

donnemartin commented May 10, 2016

Sounds good--it might be pretty involved. Some things off the top of my head that will need to change:

  • Current calls to config.api will need to support of GitHub and GitLab
  • Authentication login in config.py

If anyone's interested in tackling this please contact me first so we can discuss the design.

@waltspence
Copy link

I would like to second the request formally as I use gitlab everyday 👍

@Nacoma
Copy link

Nacoma commented Jul 29, 2016

+1

@wpostma
Copy link

wpostma commented Oct 18, 2016

Hi @douglas are you working on gitlab support for this? I am interested in it and could perhaps help.

@wagoodman
Copy link

@douglas and @wpostma , I'm willing to help add support for gitlab... did either of you start work on it yet?

@wpostma
Copy link

wpostma commented Oct 27, 2016

I have not started yet. I am familiar with Gitlab internals, I have GDK installed and Gitlab-from-source working, and have both production and test systems running gitlab-omnibus that I can use to develop and test against, and I have done a bit of work in Python with the gitlab API wrapper.

Another nice python-gitlab api based tool that I have used is over here, it's used to clean old artifacts up, something gitlab itself lacks:

https://github.com/JonathonReinhart/gitlab-artifact-cleanup

From working with that, I'd say it's possible that some of the APIs we would need for this integration may require changes to python-gitlab, as Jonathon hit several areas where the api wrapper is incomplete.

@wagoodman
Copy link

I'm somewhat familiar with Gitlab but I haven't used the GDK nor worked with the Gitlab API... but I have a lot of python experience. I have been poking around the codebase for gitsome and python-gitlab a bit and I agree, there will probably be some functional changes/extensions to python-gitlab in the process of adding gitlab functionality to gitsome. I've forked this project and have started making minor tweaks... I've yet to start thinking about the best way to integrate something like python-gitlab into the project beyond the basics until I wrap my head around what's already in place.

So far, the more obvious notes I have are:

  • move the cli() function from main_cli.py to githubcli.py and delete main_cli.py
  • to change the entrypoints in setup.py to point directly to githubcli:cli
  • add a gitlab.py and gitlabcli.py to accommodate gitlab-specific API and CLI interfaces
  • add python-gitlab (or another utility) to gitsome/lib

What I haven't figured out yet is exactly how these changes will impact config.py which seems to be quite github-centric. I'm open to ideas!

@douglas
Copy link
Author

douglas commented Mar 5, 2017

Sorry! I did not started to work on this yet, have been really busy lately =(

@wpostma and @wagoodman do you still have interest on this? Perhaps we can try to hack together using appear.in or other service someday =)

@wagoodman
Copy link

@douglas I'd be for teaming up on this, but I'm probably not going to be available until May-ish (neck deep in the semester).

@douglas
Copy link
Author

douglas commented Mar 6, 2017

Hey, no problem =) I can't work on this right now as well - lets try again in May!

@metalcamp
Copy link

Any news on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants