-
Notifications
You must be signed in to change notification settings - Fork 44.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add White Background to all images #630
Labels
Comments
I’ve opened a pr. |
Otherwise you can also use "Dark dimmed" github theme |
It doesn't quite work for me, it's not dark enough and the text then too
looks quite bad on it.
…On Wed, 5 Jan 2022, 5:47 am vfdev, ***@***.***> wrote:
Otherwise you can also use "Dark dimmed" github theme
—
Reply to this email directly, view it on GitHub
<#630 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJYGZC4TMCDNRK4EFK3CYMTUUOEYBANCNFSM5KTC63YQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Maybe we can add a grey background instead of the white?
…On Sun, 16 Jan 2022, 4:55 am Harsh Batheja, ***@***.***> wrote:
It doesn't quite work for me, it's not dark enough and the text then too
looks quite bad on it.
On Wed, 5 Jan 2022, 5:47 am vfdev, ***@***.***> wrote:
> Otherwise you can also use "Dark dimmed" github theme
>
> —
> Reply to this email directly, view it on GitHub
> <#630 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AJYGZC4TMCDNRK4EFK3CYMTUUOEYBANCNFSM5KTC63YQ>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
|
it still doesn't work for me. Adding light color to arrows and text outside the boxes would be great. No need to add white/grey all over the background.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When using Dark Mode, all the image text disappears.
Example:
The text was updated successfully, but these errors were encountered: