Spelling successful..the only value

* successful * successfully * such * suffix * suitable * superfluous * support * supported * supports * suppress * swallowed * swapping * symbol * synchronize * syntax * system * target * targeting * temporary * the document * the name * the only value Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
dotnet · jsoref · Oct 20, 2023 · Oct 20, 2023 · Oct 23, 2023 · Oct 23, 2023
commit e875d09c4699fa3fc37fea51389dcd6d1d5069d9
@@ -1598,7 +1598,7 @@ Integrate dotnet/fsharp from 48f932cf8 to 085985140. Notable changes include:
 ### 0.0.85 -
 
 * Fix for FSharpSymbolUse for single case union type #301
-* Added supprt for ReturnParameter in nested functions
+* Added support for ReturnParameter in nested functions
 
 ### 0.0.84 -
 

@@ -11,7 +11,7 @@ set -u
 # This is causing it to fail
 set -o pipefail
 
-# Use in the the functions: eval $invocation
+# Use in the functions: eval $invocation
 invocation='say_verbose "Calling: ${yellow:-}${FUNCNAME[0]} ${green:-}$*${normal:-}"'
 
 # standard output may be used as a return value in the functions

@@ -19,7 +19,7 @@ type internal PrimaryAssembly =
     member Name: string
 
     /// Checks if an assembly resolution may represent a primary assembly that actually contains the
-    /// definition of Sytem.Object.  Note that the chosen target primary assembly may not actually be the one
+    /// definition of System.Object.  Note that the chosen target primary assembly may not actually be the one
     /// that contains the definition of System.Object - it is just the one we are choosing to emit for.
     static member IsPossiblePrimaryAssembly: fileName: string -> bool
 

@@ -2227,7 +2227,7 @@ let rec buildTypeDefPass3 cenv nesting modB emEnv (tdef: ILTypeDef) =
 //
 // The code in this phase is fragile.
 //
-// THe background is that System.Reflection.Emit implementations can be finickity about the
+// The background is that System.Reflection.Emit implementations can be finickity about the
 // order that CreateType calls are made when types refer to each other. Some of these restrictions
 // are not well documented, or are related to historical bugs where the F# emit code worked around the
 // underlying problems. Ideally the SRE implementation would just "work this out as it goes along" but

@@ -31,6 +31,6 @@ type options =
 /// Write a binary to the file system.
 val WriteILBinaryFile: options: options * inputModule: ILModuleDef * (ILAssemblyRef -> ILAssemblyRef) -> unit
 
-/// Write a binary to an array of bytes auitable for dynamic loading.
+/// Write a binary to an array of bytes suitable for dynamic loading.
 val WriteILBinaryInMemory:
     options: options * inputModule: ILModuleDef * (ILAssemblyRef -> ILAssemblyRef) -> byte[] * byte[] option
@@ -448,7 +448,7 @@ type IncrClassReprInfo =
         | InMethod(isStatic, methodVal, valReprInfo), _ -> 
             //dprintfn "Rewriting application of %s to be call to method %s" v.LogicalName methodVal.LogicalName
             let expr, exprTy = AdjustValForExpectedValReprInfo g m (mkLocalValRef methodVal) NormalValUse valReprInfo 
-            // Prepend the the type arguments for the class
+            // Prepend the type arguments for the class
             let tyargs = tinst @ tyargs 
             let thisArgs =
                 if isStatic then []

@@ -298,7 +298,7 @@ let rec occursCheck g un ty =
 //------------------------------------------------------------------------- 
 
 /// Some additional solutions are forced prior to generalization (permitWeakResolution=true).  These are, roughly speaking, rules
-/// for binary-operand constraints arising from constructs such as "1.0 + x" where "x" is an unknown type. THe constraint here
+/// for binary-operand constraints arising from constructs such as "1.0 + x" where "x" is an unknown type. The constraint here
 /// involves two type parameters - one for the left, and one for the right.  The left is already known to be Double.
 /// In this situation (and in the absence of other evidence prior to generalization), constraint solving forces an assumption that 
 /// the right is also Double - this is "weak" because there is only weak evidence for it.

@@ -997,7 +997,7 @@ let ResolveProvidedTypeNameInEntity (amap, m, typeName, modref: ModuleOrNamespac
 //-------------------------------------------------------------------------
 
 /// Qualified lookups of type names where the number of generic arguments is known
-/// from context, e.g. Module.Type<args>.  The full names suh as ``List`1`` can
+/// from context, e.g. Module.Type<args>.  The full names such as ``List`1`` can
 /// be used to qualify access if needed
 let LookupTypeNameInEntityHaveArity nm (typeNameResInfo: TypeNameResolutionStaticArgsInfo) (mty: ModuleOrNamespaceType) =
     let attempt1 = mty.TypesByMangledName.TryFind (typeNameResInfo.MangledNameForType nm)

@@ -558,7 +558,7 @@ type ILMethInfo =
     /// Does it appear to the user as an instance method?
     member x.IsInstance = not x.IsConstructor &&  not x.IsStatic
 
-    /// Get the argument types of the the IL method. If this is an C#-style extension method
+    /// Get the argument types of the IL method. If this is an C#-style extension method
     /// then drop the object argument.
     member x.GetParamTypes(amap, m, minst) =
         x.ParamMetadata |> List.map (fun p -> ImportParameterTypeFromMetadata amap m p.Type (fun _ -> p.CustomAttrs) x.MetadataScope x.DeclaringTypeInst minst)

@@ -278,7 +278,7 @@ type ILMethInfo =
     /// Any type parameters of the enclosing type are instantiated in the type returned.
     member GetParamNamesAndTypes: amap: ImportMap * m: range * minst: TType list -> ParamNameAndType list
 
-    /// Get the argument types of the the IL method. If this is an C#-style extension method
+    /// Get the argument types of the IL method. If this is an C#-style extension method
     /// then drop the object argument.
     member GetParamTypes: amap: ImportMap * m: range * minst: TType list -> TType list
 

@@ -181,7 +181,7 @@ type VersionFlag =
         | VersionNone -> "0.0.0.0"
 
 /// Represents a reference to an assembly. May be backed by a real assembly on disk, or a cross-project
-/// reference backed by information generated by the the compiler service.
+/// reference backed by information generated by the compiler service.
 type IRawFSharpAssemblyData =
     ///  The raw list AutoOpenAttribute attributes in the assembly
     abstract GetAutoOpenAttributes: unit -> string list
@@ -213,7 +213,7 @@ type IRawFSharpAssemblyData =
     /// Indicates if the assembly has any F# signature data attribute
     abstract HasAnyFSharpSignatureDataAttribute: bool
 
-    /// Indicates if the assembly has an F# signature data attribute auitable for use with this version of F# tooling
+    /// Indicates if the assembly has an F# signature data attribute suitable for use with this version of F# tooling
     abstract HasMatchingFSharpSignatureDataAttribute: bool
 
 /// Cache of time stamps as we traverse a project description

@@ -41,7 +41,7 @@ type IRawFSharpAssemblyData =
     /// Indicates if the assembly has any F# signature data attribute
     abstract HasAnyFSharpSignatureDataAttribute: bool
 
-    /// Indicates if the assembly has an F# signature data attribute auitable for use with this version of F# tooling
+    /// Indicates if the assembly has an F# signature data attribute suitable for use with this version of F# tooling
     abstract HasMatchingFSharpSignatureDataAttribute: bool
 
     /// Get the raw F# signature data in the assembly, if any

@@ -555,7 +555,7 @@ let ConvertSequenceExprToObject g amap overallExpr =
             let pc2lab  = Map.ofList ((pcInit, initLabel) :: (pcDone, noDisposeContinuationLabel) :: List.zip pcs labs)
             let lab2pc = Map.ofList ((initLabel, pcInit) :: (noDisposeContinuationLabel, pcDone) :: List.zip labs pcs)
 
-            // Execute phase2, building the core of the the GenerateNext, Dispose and CheckDispose methods
+            // Execute phase2, building the core of the GenerateNext, Dispose and CheckDispose methods
             let generateExprCore, disposalExprCore, checkDisposeExprCore =
                 res.phase2 (pcVarRef, currVarRef, nextVarRef, lab2pc)
 

@@ -660,7 +660,7 @@ type FSharpGenericParameterMemberConstraint =
     /// Get the name of the method required by the constraint
     member MemberName: string
 
-    /// Indicates if the the method required by the constraint must be static
+    /// Indicates if the method required by the constraint must be static
     member MemberIsStatic: bool
 
     /// Get the argument types of the method required by the constraint

@@ -405,7 +405,7 @@ interactiveTerminator:
 /* It is important to make this as large as possible given the chunk of input */
 /* text. More or less identical to 'moduleDefns' but where SEMICOLON_SEMICOLON is */
 /* not part of the grammar of topSeps and HASH interactions are not part of */
-/* the swalloed blob, since things like #use must be processed separately. */
+/* the swallowed blob, since things like #use must be processed separately. */
 /* REVIEW: limiting the input chunks until the next # directive can lead to */
 /* discrepencies between whole-file type checking in FSI and FSC. */
 

@@ -1265,7 +1265,7 @@ module Query =
     /// in terms of LINQ operators, operating over mutable tuples. Return the conversion
     /// information for the immutable-to-mutable conversion performed so we can undo it where needed.
     ///
-    /// Here 'inner' refers the the part of the query that produces a sequence of results.
+    /// Here 'inner' refers the part of the query that produces a sequence of results.
     ///
     /// The output query will use either Queryable.* or Enumerable.* operators depending on whether
     /// the inputs to the queries have type IQueryable or IEnumerable.

@@ -2189,7 +2189,7 @@ module DerivedPatterns =
     /// </code>
     /// Evaluates <c>implExpr</c> to a quotation with the same structure as <c>&lt;@ fun (x: int) -> (x, x) @&gt;</c>, which is the implementation of the
     /// method <c>f</c>. Note that the correct generic instantiation has been applied to the implementation to reflect
-    /// the the type at the callsite.
+    /// the type at the callsite.
     /// </example>
     ///
     [<CompiledName("MethodWithReflectedDefinitionPattern")>]
@@ -2220,7 +2220,7 @@ module DerivedPatterns =
     /// </code>
     /// Evaluates <c>implExpr</c> to a quotation with the same structure as <c>&lt;@ fun (x: C&lt;int&gt;) () -> x @&gt;</c>, which is the implementation of the
     /// property <c>Identity</c>. Note that the correct generic instantiation has been applied to the implementation to reflect
-    /// the the type at the callsite.
+    /// the type at the callsite.
     /// </example>
     ///
     [<CompiledName("PropertyGetterWithReflectedDefinitionPattern")>]
@@ -2251,7 +2251,7 @@ module DerivedPatterns =
     /// </code>
     /// Evaluates <c>implExpr</c> to a quotation with the same structure as <c>&lt;@ fun (x: C&lt;int&gt;) (v: int) -> () @&gt;</c>, which is the implementation of the
     /// setter for the property <c>Count</c>. Note that the correct generic instantiation has been applied to the implementation to reflect
-    /// the the type at the callsite.
+    /// the type at the callsite.
     /// </example>
     ///
     [<CompiledName("PropertySetterWithReflectedDefinitionPattern")>]

@@ -8747,7 +8747,7 @@ namespace ProviderImplementation.ProvidedTypes
             | ShapeVarUnchecked v ->
                 Expr.Var (convVarToTgt v)
             | ShapeLambdaUnchecked _ as d ->
-                failwithf "It's not possible to use construct %O when cross targetting to a different FSharp.Core. Make sure you're not calling a function with signature A->(B->C) instead of A->B->C (using |> causes this)." d
+                failwithf "It's not possible to use construct %O when cross targeting to a different FSharp.Core. Make sure you're not calling a function with signature A->(B->C) instead of A->B->C (using |> causes this)." d
             | ShapeCombinationUnchecked (o, exprs) ->
                 RebuildShapeCombinationUnchecked (o, List.map convExprToTgt exprs)
 
@@ -10077,7 +10077,7 @@ namespace ProviderImplementation.ProvidedTypes
         // -------------------------------------------------------------------- 
         // ILMethodRef --> ILMethodDef.  
         // 
-        // Only successfuly converts ILMethodRef's referring to 
+        // Only successfully converts ILMethodRef's referring to 
         // methods in the module being emitted.
         // -------------------------------------------------------------------- 
 

@@ -1,5 +1,5 @@
 // #Regression #Conformance #DeclarationElements #Attributes 
-// FSharp1.0:4780 - Attributes targetting constructors are not allowed on explicit constructors 'new() = { ... }'
+// FSharp1.0:4780 - Attributes targeting constructors are not allowed on explicit constructors 'new() = { ... }'
 // Make sure custom attributes can be applied to explicit and implicit constructors
 
 #light

@@ -1,7 +1,7 @@
 // #Conformance #TypesAndModules #Records 
 #light
 
-// Verify sytanx associated with defining and creating records
+// Verify syntax associated with defining and creating records
 
 // Same line
 type Rec1 = { A1 : int; B1 : string }

@@ -1402,7 +1402,7 @@ Actual:
 
             verifyPdbFormat reader compilationType
             verifyPdbOptions result.OutputPath reader options
-        | _ -> failwith "Output path is not set, please make sure compilation was successfull."
+        | _ -> failwith "Output path is not set, please make sure compilation was successful."
 
         ()
 
@@ -1420,7 +1420,7 @@ Actual:
                 let pdbPath = Path.ChangeExtension(assemblyPath, ".pdb")
                 if not (FileSystem.FileExistsShim pdbPath) then
                     failwith $"PDB file does not exists: {pdbPath}"
-            | _ -> failwith "Output path is not set, please make sure compilation was successfull."
+            | _ -> failwith "Output path is not set, please make sure compilation was successful."
         match result with
         | CompilationResult.Success r -> verifyPdbExists r
         | _ -> failwith "Result should be \"Success\" in order to verify PDB."
@@ -1432,7 +1432,7 @@ Actual:
                 let pdbPath = Path.ChangeExtension(assemblyPath, ".pdb")
                 if FileSystem.FileExistsShim pdbPath then
                     failwith $"PDB file exists: {pdbPath}"
-            | _ -> failwith "Output path is not set, please make sure compilation was successfull."
+            | _ -> failwith "Output path is not set, please make sure compilation was successful."
         match result with
         | CompilationResult.Success r -> verifyPdbNotExists r
         | _ -> failwith "Result should be \"Success\" in order to verify PDB."

@@ -182,7 +182,7 @@ type RunConfig =
         BaseDir : string
         /// How many revisions should be checked out and built in parallel
         Parallelism : int
-        /// Name to suffx the benchmark result files with
+        /// Name to suffix the benchmark result files with
         ResultsSuffix : string
         /// Whether to build local codebases before benchmarking
         BuildLocalCodebases : bool

@@ -1844,7 +1844,7 @@ module TestConstrainedItemProperty = begin
 end
 
 
-module ExplicitSyntacCtor = begin
+module ExplicitSyntaxCtor = begin
 
     type C =
        class

@@ -122,7 +122,7 @@ module OverloadSamples =
     type 'a GenericVector 
       with
         // Nb. For an operator associated with a generic type 
-        // the the type parameters involved in the operator's definition must be the same 
+        // the type parameters involved in the operator's definition must be the same 
         // as the type parameters of the enclosing class.
         static member (+) ((x : 'a GenericVector),(y : 'a GenericVector)) = add x y
       end

@@ -127,7 +127,7 @@ module OverloadSamples =
     type 'a GenericVector 
       with
         // Nb. For an operator associated with a generic type 
-        // the the type parameters involved in the operator's definition must be the same 
+        // the type parameters involved in the operator's definition must be the same 
         // as the type parameters of the enclosing class.
         static member (+) ((x : 'a GenericVector),(y : 'a GenericVector)) = add x y
       end

@@ -2156,7 +2156,7 @@ module IndexedPropertySetTest =
             | PropertySet (inst, pi, l, es) ->
                 match inst with
                 | Some(e) ->
-                    Expr.PropertySet(e, pi, es, l) // swaping params 2 and 3 e.g. (e, pi, l.[0], [es]) yield to OK
+                    Expr.PropertySet(e, pi, es, l) // swapping params 2 and 3 e.g. (e, pi, l.[0], [es]) yield to OK
                 | _ -> failwith ""
             | _ -> failwith ""   
 

@@ -327,7 +327,7 @@ let singleTestBuildAndRunCore cfg copyFiles p languageVersion =
 
     | FSC_NETFX_TEST_ROUNDTRIP_AS_DLL ->
         // Compile as a DLL to exercise pickling of interface data, then recompile the original source file referencing this DLL
-        // THe second compilation will not utilize the information from the first in any meaningful way, but the
+        // The second compilation will not utilize the information from the first in any meaningful way, but the
         // compiler will unpickle the interface and optimization data, so we test unpickling as well.
         use _cleanup = (cleanUpFSharpCore cfg)
         use testOkFile = new FileGuard (getfullpath cfg "test.ok")

@@ -877,7 +877,7 @@ type public Provider(config: TypeProviderConfig) =
                              else Quotations.Expr.Call(e,tagMeth,[])
                         | _ -> failwith "unreachable: unexpected result from PreComputeUnionTagMemberInfo"
                     let tagNumber = uc.Tag
-                    // Translate to a call the the F# library equality routine
+                    // Translate to a call the F# library equality routine
                     trans <@@ (%%(tagExpr) : int) = tagNumber @@>
 
                 // Handle the generic cases

@@ -473,6 +473,6 @@ module InterfacesOfMeasureAnnotatedTypes =
     [<MeasureAnnotatedAbbreviation>]
     type Prim<[<Measure>] 'm> = Prim
 
-    // Check that Prim<'m> does not suppor interfaces in any way derived from IComparable and IEquatable
+    // Check that Prim<'m> does not support interfaces in any way derived from IComparable and IEquatable
     let f2 (x: Prim<'m>) = (x :> IDerivedComparable<Prim<'m>>)
     let f4 (x: Prim<'m>) = (x :> IDerivedEquatable<Prim<'m>>)
@@ -1,7 +1,7 @@
 // #Conformance #LexicalAnalysis 
 #light
 
-// Verify no stynax errors or problems when using XML doc comments
+// Verify no syntax errors or problems when using XML doc comments
 
 /// Not associated with anything
 

@@ -18,7 +18,7 @@ if baseTypeName<InterfaceType> <> null then exit 1
 type AClass() =
     interface InterfaceType
 
-// Note how an interface has '.ToString()' despite not being derived from Syste.Object
+// Note how an interface has '.ToString()' despite not being derived from System.Object
 let anInterface = (new AClass() :> InterfaceType)
 if anInterface.ToString().EndsWith("AClass") = false then exit 1
 

@@ -1,5 +1,5 @@
 // #Regression #Conformance #TypeConstraints 
-// Verify the [<AllowNullLiteral>] attribute is only valud on class and interface types
+// Verify the [<AllowNullLiteral>] attribute is the only value on class and interface types
 
 //<Expects id="FS0934" span="(10,6-10,15)" status="error">Records, union, abbreviations and struct types cannot have the 'AllowNullLiteral' attribute</Expects>
 //<Expects id="FS0934" span="(22,6-22,12)" status="error">Records, union, abbreviations and struct types cannot have the 'AllowNullLiteral' attribute</Expects>

@@ -1,6 +1,6 @@
 // #Regression #NoMT #FSI #NoMono 
 // Regression for FSB 1711
-// Generic Interface requires a method implementation that in some cases is not suppored by FSI
+// Generic Interface requires a method implementation that in some cases is not supported by FSI
 
 type IFoo<'a> =
     abstract InterfaceMethod<'b> : 'a -> 'b