Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[E2B-438] Move start command handling in Python SDK to a thread #252

Closed
ValentaTomas opened this issue Dec 8, 2023 · 1 comment
Closed
Labels
Improvement Created by Linear-GitHub Sync SDK Created by Linear-GitHub Sync

Comments

@ValentaTomas
Copy link
Member

ValentaTomas commented Dec 8, 2023

The Python SDK is sync. We are starting process during Sandbox opening that forwards logs from the start command (this process is called even when there is no start command because we don't know that beforehand) by calling .process.start in the main thread. This blocks the thread for a short time.
We can move this call to a separate thread to make the sandbox opening quicker.

Fixing this would improve the sandbox startup time from Python SDK.

From SyncLinear.com | E2B-438

@ValentaTomas ValentaTomas added SDK Created by Linear-GitHub Sync Improvement Created by Linear-GitHub Sync labels Dec 8, 2023
@ValentaTomas ValentaTomas changed the title Move start command handling in Python SDK to a thread [E2B-438] Move start command handling in Python SDK to a thread Dec 8, 2023
@ValentaTomas
Copy link
Member Author

Fixed by:

@ValentaTomas ValentaTomas added this to the v.22 milestone Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Created by Linear-GitHub Sync SDK Created by Linear-GitHub Sync
Projects
None yet
Development

No branches or pull requests

1 participant