feat: expose StoreAction in relation to multiplayer history
#7898
+340
−189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
07bc0a4
to
7f46b31
Compare
7f46b31
to
a04f6ac
Compare
…otential concurrency issues
a04f6ac
to
1f2cb61
Compare
StoreAction in relation to multiplayer history
496a7e4
to
ce7fd9c
Compare
ce7fd9c
to
03c9075
Compare
dwelle
reviewed
Apr 21, 2024
| @@ -3683,51 +3682,38 @@ class App extends React.Component<AppProps, AppState> { | |||
| elements?: SceneData["elements"]; | |||
| appState?: Pick<AppState, K> | null; | |||
| collaborators?: SceneData["collaborators"]; | |||
| commitToStore?: SceneData["commitToStore"]; | |||
| storeAction?: SceneData["storeAction"]; | |||
There was a problem hiding this comment.
let's note the default here? (as a tsdoc /** */ so it shows in intellisense)
dwelle
approved these changes
Apr 21, 2024
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced breaking change in
updateSceneAPI due to the addedStorecomponent as part of the #7348. Specifically,sceneDatapropertycommitToHistory: booleanwas replaced withstoreAction: StoreActionType.Additional small improvements:
Storemethods, internal API & public API (i.e. introducedcommit)updateScenemodifying store before already scheduled store actions executeAppStatein shared scenes (collab)