Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0.5 - find precision minor change #43

Merged
merged 3 commits into from
May 15, 2024
Merged

Conversation

JasonLing95
Copy link
Collaborator

@JasonLing95 JasonLing95 commented May 14, 2024

Change

  • added minor log print for clarity in logging
  • in find_precision function, change to find only file with archivalStatus = live

This change is Reviewable

@pep8speaks
Copy link

pep8speaks commented May 14, 2024

Hello @JasonLing95! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 263:80: E501 line too long (90 > 79 characters)

Comment last updated at 2024-05-15 08:43:27 UTC

Copy link
Contributor

@corbin-chris corbin-chris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @JasonLing95)

@corbin-chris corbin-chris merged commit 0df1007 into main May 15, 2024
1 check passed
@corbin-chris corbin-chris deleted the precision-minor-fix branch May 15, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants