Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move quotes around to help Powershell 2.0 to substitute variables values. #14907

Merged
merged 1 commit into from
Feb 27, 2018
Merged

Move quotes around to help Powershell 2.0 to substitute variables values. #14907

merged 1 commit into from
Feb 27, 2018

Conversation

aam
Copy link
Member

@aam aam commented Feb 27, 2018

This should fix #12666

@aam aam mentioned this pull request Feb 27, 2018
Closed
@aam aam requested a review from goderbauer February 27, 2018 03:21
goderbauer
goderbauer approved these changes Feb 27, 2018
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tvolkert
tvolkert approved these changes Feb 27, 2018
View reviewed changes
Copy link
Contributor

@tvolkert tvolkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aam aam merged commit 3b84503 into flutter:master Feb 27, 2018
@aam aam deleted the fix-parens branch February 27, 2018 04:11
@NathanaelA NathanaelA mentioned this pull request Mar 2, 2018
Closed
DaveShuckerow pushed a commit to DaveShuckerow/flutter that referenced this pull request May 14, 2018
@aam
Move quotes around to help Powershell 2.0 to substitute variable with…
241dc52 
… value (flutter#14907)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@goderbauer goderbauer goderbauer approved these changes

@tvolkert tvolkert tvolkert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to 'pub upgrade' flutter tool.
4 participants
@aam @goderbauer @tvolkert @googlebot