Allow changing a clipper's type (ShapeBorderClipper,_BottomAppBarClipper). #14937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…per). The downcast was crashing when toggling hasNotch for BottomAppBar.
HansMuller
reviewed
Feb 28, 2018
| @@ -86,6 +86,37 @@ void main() { | |||
| expect(physicalShape.color, const Color(0xff0000ff)); | |||
| }); | |||
|
|
|||
| testWidgets('toggle hasNotch', (WidgetTester tester) async { | |||
| await tester.pumpWidget( | |||
There was a problem hiding this comment.
A comment explaining why we're toggling hasNotch...
|
LGTM |
Hixie
reviewed
Mar 8, 2018
| bool shouldReclip(covariant _BottomAppBarClipper oldClipper) { | ||
| return oldClipper.geometry != geometry; | ||
| bool shouldReclip(CustomClipper<Path> oldClipper) { | ||
| if (oldClipper.runtimeType != _BottomAppBarClipper) |
There was a problem hiding this comment.
this is impossible. oldClipped is guaranteed to have the same runtimeType as this
(unless there's a bug in the code that calls shouldReclip, which is possible)
|
I think this fix is incorrect. The |
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
…per). (flutter#14937) The downcast was crashing when toggling hasNotch for BottomAppBar.
|
cc @amirh see comment above |
amirh
pushed a commit
to amirh/flutter
that referenced
this pull request
Jun 6, 2018
A bug in _RenderCustomClip was compaeing the type of oldClipper to itself instead to the type of newClipper. This was the root cause for the crash flutter#14937 worked around. This also reverts the workaround introduced in flutter#14937.
|
Looks like there was indeed a bug in _RenderCustomClip, sent a fix in #18248. |
amirh
added a commit
that referenced
this pull request
Jun 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The downcast was crashing when toggling hasNotch for BottomAppBar.