_SaltedKey solution to ExpansionPanelList
#11902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hixie
reviewed
Sep 6, 2017
| @@ -70,5 +70,52 @@ void main() { | |||
| expect(find.text('B'), findsOneWidget); | |||
| box = tester.renderObject(find.byType(ExpansionPanelList)); | |||
| expect(box.size.height - oldHeight, greaterThanOrEqualTo(100.0)); // 100 + some margin | |||
|
|
|||
| // multiple panel list test | |||
There was a problem hiding this comment.
you should put this in a separate testWidgets call, with this comment as the title of the test
Hixie
reviewed
Sep 6, 2017
| home: new ListView( | ||
| children: <ExpansionPanelList>[ | ||
| new ExpansionPanelList( | ||
| expansionCallback: (int _index, bool _isExpanded){ |
Hixie
reviewed
Sep 6, 2017
| new ExpansionPanelList( | ||
| expansionCallback: (int _index, bool _isExpanded){ | ||
| index = _index; | ||
| isExpanded = _isExpanded; |
There was a problem hiding this comment.
since you don't actually interact with this widget, you can probably just leave the callback empty (or maybe omit it altogether?)
Hixie
reviewed
Sep 6, 2017
| headerBuilder: (BuildContext context, bool isExpanded) { | ||
| return new Text(isExpanded ? 'B': 'A'); | ||
| }, | ||
| body: const SizedBox(height:100.0), |
There was a problem hiding this comment.
minor style nit: space after :
Hixie
reviewed
Sep 6, 2017
| body: const SizedBox(height:100.0), | ||
| isExpanded: true, | ||
| ), | ||
| ], |
Hixie
reviewed
Sep 6, 2017
|
|
||
| expect(find.text('A'), findsNothing); | ||
| expect(find.text('B'), findsOneWidget); | ||
| // Multiple panel lists scenario only fails when expanded |
|
That test will be fine, just some minor tweaks needed before we land it. Thanks! |
|
@Skylled Thanks for your contribution, I'm going to land this as-is and if there's any more style nits we'll fix them in post. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_SaltedKey implementation courtesy of @Hixie
Tested and confirmed working. Screenshot
Fixes #11166