AspectRatio has incorrect intrinsic sizing #3666
Merged
+34
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still needs a test. |
| @@ -374,6 +374,8 @@ class RenderAspectRatio extends RenderProxyBox { | |||
| RenderBox child, | |||
| double aspectRatio | |||
| }) : _aspectRatio = aspectRatio, super(child) { | |||
| assert(newAspectRatio > 0.0); | |||
There was a problem hiding this comment.
these two need to be _aspectRatio
2375a92
to
3016321
Compare
| @@ -374,6 +374,8 @@ class RenderAspectRatio extends RenderProxyBox { | |||
| RenderBox child, | |||
| double aspectRatio | |||
| }) : _aspectRatio = aspectRatio, super(child) { | |||
| assert(_aspectRatio > 0.0); | |||
| assert(_aspectRatio < double.INFINITY); | |||
There was a problem hiding this comment.
_aspectRatio.isFinite is probably better
|
|
If there's a max height or width, we should factor that into the intrinsic sizing for the other dimension.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there's a max height or width, we should factor that into the intrinsic
sizing for the other dimension.