Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ModalPosition #3734

Merged
merged 1 commit into from
May 4, 2016
Merged

Remove ModalPosition #3734

merged 1 commit into from
May 4, 2016

Conversation

abarth
Copy link
Contributor

@abarth abarth commented May 4, 2016

Clients of getPosition should just use a one-child custom layout delegate
instead.

Fixes #2484

@abarth
Copy link
Contributor Author

abarth commented May 4, 2016

@Hixie

@Hixie
Copy link
Contributor

Hixie commented May 4, 2016

Lgtm

@abarth
Remove ModalPosition
9e57134 
Clients of getPosition should just use a one-child custom layout delegate
instead.

Fixes flutter#2484
@abarth abarth merged commit a5eb4c0 into flutter:master May 4, 2016
@abarth abarth deleted the rm_modal_position branch May 4, 2016 19:40
Hixie added a commit to Hixie/flutter that referenced this pull request May 6, 2016
@Hixie
Remove ModalPosition (for real)
c24cf44 
It has no more clients.

Follow-up to flutter#3734.

Fixes flutter#2484
@Hixie Hixie mentioned this pull request May 6, 2016
Merged
Hixie added a commit that referenced this pull request May 6, 2016
@Hixie
Remove ModalPosition (for real)
4d9fdda 
It has no more clients.

Follow-up to #3734.

Fixes #2484
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace ModalPosition with RelativeRect
2 participants
@abarth @Hixie