Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer implict equals matcher in test expectations. #3739

Merged
merged 1 commit into from May 4, 2016
Merged

Prefer implict equals matcher in test expectations. #3739

merged 1 commit into from May 4, 2016

Conversation

pq
Copy link
Contributor

@pq pq commented May 4, 2016

@Hixie: as per our conversation, using the implicit equals matcher (see test docs here) can make expectations a wee bit more concise.

@pq
Prefer implict equals matcher in test expectations.
79d1d3a 
@Hixie: as per our conversation, a little more concise.
@pq
Copy link
Contributor Author

pq commented May 4, 2016

cc @devoncarew

@Hixie
Copy link
Contributor

Hixie commented May 4, 2016

LGTM

@pq pq merged commit 0e51563 into flutter:master May 4, 2016
@pq pq deleted the eq_matcher_cleanup branch August 11, 2016 17:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pq @Hixie