Ensure that DropDownMenus are always onscreen #3742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// Abstract const constructor. This constructor enables subclasses to provide | ||
| /// const constructors so that they can be used in const expressions. | ||
| const CustomPainter(); | ||
| /// The painter will repaint whenever the [repaint] animation ticks. |
|
|
This patch sizes the menu such that it is always on screen, but doesn't scroll the menu to ensure that the currently selected item is always visible and on top of the button. That will need to wait for a later patch. Also, teach CustomPaint how to repaint animations more efficiently. Fixes flutter#3720
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch sizes the menu such that it is always on screen, but doesn't scroll
the menu to ensure that the currently selected item is always visible and on
top of the button. That will need to wait for a later patch.
Also, teach CustomPaint how to repaint animations more efficiently.
Fixes #3720