Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Box/Sliver mismatches should have better error messages #9525

Merged
merged 1 commit into from
Apr 21, 2017

Conversation

abarth
Copy link
Contributor

@abarth abarth commented Apr 21, 2017

We now attempt to explain what went wrong.

Fixes #9509

@Hixie
Copy link
Contributor

Hixie commented Apr 21, 2017

LGTM, but travis is angry.

@abarth
Copy link
Contributor Author

abarth commented Apr 21, 2017

[lint] Prefer const with constant constructors. (packages/flutter/test/widgets/box_sliver_mismatch_test.dart, line 48, col 11)

coooooonnnnnnssssssttttt!

We now attempt to explain what went wrong.

Fixes flutter#9509
@abarth abarth merged commit 9301839 into flutter:master Apr 21, 2017
@abarth abarth deleted the box_sliver_mismatch branch April 21, 2017 21:09
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better error message when a box layout widget is added instead of sliver layout
3 participants