Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

query_runner -> query_results: improve logging, handle unhandled data types #6905

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
+63 −1
Open

query_runner -> query_results: improve logging, handle unhandled data types #6905

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
aa7b93c
query_runner: add debug log
vtatarin Apr 18, 2024
fb4163c
query_runner: add debug log
vtatarin Apr 18, 2024
4e7e468
handle datetime.time
vtatarin Apr 18, 2024
11e4f0b
query_runner: add debug log
vtatarin Apr 18, 2024
1f4853e
fmt
vtatarin Apr 18, 2024
e0ae3ba
add debug
vtatarin Apr 18, 2024
051ed07
athena ds: fallback to default creds if RoleArn is not provided
vtatarin Apr 18, 2024
71e433a
pull changes
vtatarin Apr 18, 2024
17c00d6
pull changes
vtatarin Apr 18, 2024
512bde7
Merge branch 'master' of github.com:vtatarin/redash into fix-query-ru…
vtatarin Apr 18, 2024
be111d3
expose error messae
vtatarin Apr 19, 2024
26b5f7c
expose error messae
vtatarin Apr 19, 2024
8d155bf
revert additional changes
vtatarin Apr 19, 2024
374e6bf
revert additional changes
vtatarin Apr 19, 2024
1a7f204
revert additional changes
vtatarin Apr 19, 2024
d22df7c
Update redash/query_runner/query_results.py
vtatarin Apr 29, 2024
30776b3
review edits
vtatarin Apr 29, 2024
c9feda5
Merge branch 'getredash:master' into fix-query-runner
vtatarin Apr 29, 2024
a181ba9
add tests
vtatarin Apr 30, 2024
d3f8cad
add tests
vtatarin Apr 30, 2024
0778b71
fmt
vtatarin Apr 30, 2024
a8023fb
fix
vtatarin Apr 30, 2024
4e3cbdb
fix lint
vtatarin Apr 30, 2024
5e69e3f
fix lint
vtatarin Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
Next Next commit
fmt
  • Loading branch information
@vtatarin
vtatarin committed Apr 18, 2024
commit 1f4853eb1ce2c86464553df4bf4f03621b1d9c94
10 changes: 6 additions & 4 deletions redash/query_runner/query_results.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,10 +144,12 @@ def create_table(connection, table_name, query_results):
try:
connection.execute(insert_template, values)
except sqlite3.InterfaceError as exc:
raise UnsupportedTypeError("Error inserting data: %s. Template: %s. Value data types: %s",
str(exc),
insert_template,
",".join(str(type(value)) for value in values))
raise UnsupportedTypeError(
"Error inserting data: %s. Template: %s. Value data types: %s",
str(exc),
insert_template,
",".join(str(type(value)) for value in values),
)


def prepare_parameterized_query(query, query_params):
Expand Down