Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commands: improve "Go: Add Package to Workspace" in module mode #170

Open
stamblerre opened this issue Jun 3, 2020 · 3 comments
Open

commands: improve "Go: Add Package to Workspace" in module mode #170

stamblerre opened this issue Jun 3, 2020 · 3 comments
Labels
FeatureRequest NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.

Comments

@stamblerre
Copy link
Contributor

See the discussion on microsoft/vscode-go#3195. We should improve the error reporting for this command and consider alternative ways for how this could work in module mode.

@stamblerre stamblerre added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 4, 2020
@hyangah hyangah added this to the Backlog milestone Aug 7, 2020
@simon0-o
Copy link

Are there any updates? This would be very convenient to view the source code of packages imported. Especially when I have to search within imported packages, now I have to launch a new window or use the integrated terminal.

@findleyr findleyr modified the milestones: Unplanned, Untriaged Jan 21, 2022
@findleyr
Copy link
Contributor

findleyr commented Feb 7, 2022

We discussed this in our triage meeting triage. It's a little unclear how to make this work: imported packages could be in GOCACHE.

@simon0-o how would you like this feature to behave, particularly if the package is in the module cache?

@suzmue suzmue added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Feb 8, 2022
@hyangah
Copy link
Contributor

hyangah commented Mar 25, 2022

@findleyr How bad can it be if we add the folders in the module cache as workspace folders?
I think that can help #2080 (ability to search code in dependency) or
https://stackoverflow.com/questions/71523201/how-to-view-external-go-module-dependencies-in-vscode.

I don't want though those folders to be diagnosed or cause to bloat gopls's memory usage footprint too much, etc
even though I appreciate analysis like reference, implemented-by, go-to-definition, documentation, ...
And, some modules in the module cache may not have go.mod file (the implicit module the go command creates to handle pre-module-time packages)

Does current gopls's data model (Session/View) handle this use case - folders in the workspace are not independent?

@hyangah hyangah added FeatureRequest and removed WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. labels Mar 25, 2022
@hyangah hyangah modified the milestones: Untriaged, On Deck Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FeatureRequest NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

5 participants