Skip to content

Commit

Permalink
Improve dartdoc for SystemChrome and SystemSound (flutter#3669)
Browse files Browse the repository at this point in the history
We need to import these enums in order for the dartdoc to linkify correctly.

Fixes flutter#3668
  • Loading branch information
abarth committed May 2, 2016
1 parent cd8f65d commit 0910a78
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 5 deletions.
4 changes: 2 additions & 2 deletions packages/flutter/lib/src/services/path_provider.dart
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ class PathProvider {
///
/// Examples:
///
/// * iOS: `NSDocumentsDirectory`
/// * Android: The AppData directory.
/// * _iOS_: `NSDocumentsDirectory`
/// * _Android_: The AppData directory.
static Future<Directory> getApplicationDocumentsDirectory() async {
return new Directory((await _pathProviderProxy.ptr.applicationDocumentsDirectory()).path);
}
Expand Down
5 changes: 3 additions & 2 deletions packages/flutter/lib/src/services/system_chrome.dart
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import 'dart:async';

import 'package:sky_services/flutter/platform/system_chrome.mojom.dart' as mojom;
import 'package:sky_services/flutter/platform/system_chrome.mojom.dart';

import 'shell.dart';

Expand All @@ -27,7 +28,7 @@ class SystemChrome {
///
/// Arguments:
///
/// * `device_orientation_mask`: A mask of `DeviceOrientation` enum values.
/// * [deviceOrientationMask]: A mask of [DeviceOrientation] enum values.
/// The value 0 is synonymous with having all options enabled.
///
/// Return Value:
Expand All @@ -44,7 +45,7 @@ class SystemChrome {
///
/// Arguments:
///
/// * `style`: A mask of `SystemUIOverlay` enum values that denotes the overlays
/// * [style]: A mask of [SystemUIOverlay] enum values that denotes the overlays
/// to show.
///
/// Return Value:
Expand Down
3 changes: 2 additions & 1 deletion packages/flutter/lib/src/services/system_sound.dart
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import 'dart:async';

import 'package:sky_services/flutter/platform/system_sound.mojom.dart' as mojom;
import 'package:sky_services/flutter/platform/system_sound.mojom.dart' show SystemSoundType;

import 'shell.dart';

Expand All @@ -31,7 +32,7 @@ class SystemSound {
/// boolean indicating if the intent to play the specified sound was
/// successfully conveyed to the embedder. No sound may actually play if the
/// device is muted or the sound was not available on the platform.
static Future<bool> play(mojom.SystemSoundType type) async {
static Future<bool> play(SystemSoundType type) async {
return (await _systemChromeProxy.ptr.play(type)).success;
}
}

0 comments on commit 0910a78

Please sign in to comment.