Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jaeger-v2]: Remove SkipBinaryAttrs flag from storage integration #5341

Closed
james-ryans opened this issue Apr 9, 2024 · 2 comments · Fixed by #5436
Closed

[jaeger-v2]: Remove SkipBinaryAttrs flag from storage integration #5341

james-ryans opened this issue Apr 9, 2024 · 2 comments · Fixed by #5436
Labels
enhancement

Comments

@james-ryans
Copy link
Contributor

Requirement

As a contributor, I want to remove the SkipBinaryAttrs flag from storage integration test that was temporarily added to bypass the issue sourced from upstream dependency. Marked with this comment #5322 (comment).

Problem

The SkipBinaryAttrs flag was added to bypass upstream issue because OTEL pkg/translator/jaeger has a bug that converts Jaeger proto BINARY type tags into OTLP STRING type but remains in STRING type when converted back into Jaeger proto.

Proposal

Remove SkipBinaryAttrs flag from storage integration test once the issue at open-telemetry/opentelemetry-collector-contrib#32208 has been resolved.

Open questions

No response
@james-ryans james-ryans mentioned this issue Apr 9, 2024
Merged
4 tasks
@prakrit55
Copy link
Contributor

hey @james-ryans. @yurishkuro I would like to work on it

@james-ryans james-ryans mentioned this issue May 11, 2024
Merged
4 tasks
@james-ryans
Copy link
Contributor Author

Hi @prakrit55, actually we have an ongoing PR for this at #5436.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[v2] Remove temporary SkipBinaryAttrs flag from e2e tests james-ryans/jaeger
2 participants
@james-ryans @prakrit55